[HUDI-7507] Adding timestamp ordering validation before creating requested instant #11580
+218
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
nsivabalan
force-pushed
the
branch-0x-HUDI-7507
branch
from
3a1c57e
to
4c398ca
Compare
kbuci
reviewed
Jul 13, 2024
| @@ -931,6 +932,7 @@ private void startCommit(String instantTime, String actionType, HoodieTableMetaC | |||
| "Found pending restore in active timeline. Please complete the restore fully before proceeding. As of now, " | |||
| + "table could be in an inconsistent state. Pending restores: " + Arrays.toString(inflightRestoreTimeline.getInstantsAsStream() | |||
| .map(instant -> instant.getTimestamp()).collect(Collectors.toList()).toArray())); | |||
| TimestampUtils.validateForLatestTimestamp(metaClient, instantTime); | |||
There was a problem hiding this comment.
As discussed, this will need to be under a transaction as well.
nsivabalan
force-pushed
the
branch-0x-HUDI-7507
branch
from
86cbcab
to
74330eb
Compare
nsivabalan
commented
Jul 15, 2024
There was a problem hiding this comment.
hey @yihua or @codope or @danny0405 : can one of you review this patch
danny0405
reviewed
Jul 16, 2024
| @@ -113,6 +113,7 @@ protected Option<HoodieRollbackPlan> requestRollback(String startRollbackTime) { | |||
| HoodieRollbackPlan rollbackPlan = new HoodieRollbackPlan(new HoodieInstantInfo(instantToRollback.getTimestamp(), | |||
| instantToRollback.getAction()), rollbackRequests, LATEST_ROLLBACK_PLAN_VERSION); | |||
| if (!skipTimelinePublish) { | |||
| table.validateForLatestTimestamp(rollbackInstant.getTimestamp()); | |||
There was a problem hiding this comment.
Only the compaction instant timestamp should be kept serial with the regular instant timestamps, the other table actions are okay (for e.g. clustering, rollback, cleaning).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
When multiple writers trigger table services, there is a chance that one of them could create requested in a different ordering compared to the actual timestamp. Linked jira has more details of the scenario w/ an illustration. This patch, ensure that before creating a requested entry in the timeline, there is no other instant greater than the current instant time.
Major reason is, a writer could generate a new commit time in memory (say t10), and then take a long time to do some computation and eventually add the requested instant to timeline very late (say t100). In b/w these two time, there could be another concurrent writer choosing t25 as commit time and proceed. This might lead to unexpected behaviors as called out in the jira.
This patch is for 0.x branch.
here is the equivalent 1.x branch PR #11344
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist