Skip to content

Conversation

@yihua
Copy link
Contributor

@yihua yihua commented Jun 20, 2024

Change Logs

This PR adds support for compiling Hudi on Java 11 for engines like Spark and Flink that support Java 11 and 17. Detailed changes:

  • Fixes compilation errors on Java 11; maintains the code to be compilable on Java 8.
  • Adds new GitHub CI jobs on validating Hudi built by Java 11, by running the tests on Spark 3.5 with Java 17 runtime. These are moved from existing CI jobs validating Hudi built by Java 8. The tests on Spark 3.3 and 3.4 still run with Java 8 compilation and Java 17 runtime.

Kudos to @Zouxxyy for contributing to this PR from #9300.

Impact

Makes Hudi compilable on Java 11.

Risk level

none

Documentation Update

Docs on Java 11 compilation support.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Jun 20, 2024
Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do end to end testing/certification before we land this

@nsivabalan
Copy link
Contributor

I see some CI failures. do follow up before we land the patch.

@yihua
Copy link
Contributor Author

yihua commented Jun 21, 2024

Lets do end to end testing/certification before we land this

I added Spark tests with Java 11 build and bundle validation on bundles generated by Java 11 build. So the functionality is certified. The CI failure is irrelevant to the changes in this PR, which also happens in other PRs. I'm looking into that. I'll land the PR once CI is green.

@yihua yihua force-pushed the HUDI-6508-java11-build branch from eac32a5 to c019fbd Compare June 22, 2024 03:00
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua
Copy link
Contributor Author

yihua commented Jun 22, 2024

Azure CI is green.
Screenshot 2024-06-21 at 22 43 19

@yihua yihua merged commit bb76de4 into apache:master Jun 22, 2024
yihua added a commit to yihua/hudi that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants