[HUDI-7699] Support STS external ids and configurable session names in the AWS StsAssumeRoleCredentialsProvider #11134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the AWS StsAssumeRoleCredentialsProvider [HUDI-6695](https://issues.apache.org/jira/browse/HUDI-6695) added a AWS credentials provider to support assuming a role when syncing to Glue. We use Hudi in a multi-tenant environment, and our customers give us delegated access to their Glue catalog. In this multi-tenant setup it is important to use [an external ID](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html) to improve security when assuming IAM roles. Furthermore, the STS session name is currently hard-coded to "hoodie". It is helpful for us to have configurable session names so we have better tracability of what entities are creating STS sessions in the cloud. Currently, the assumed role is configured with the `hoodie.aws.role.arn` config property. I would like to add the following extra optional config properties, which will be used by the `HoodieConfigAWSAssumedRoleCredentialsProvider`: - `hoodie.aws.role.external.id` - `hoodie.aws.role.session.name`
Collaborator
danny0405
approved these changes
May 2, 2024
Contributor
Author
|
Thank you @danny0405 for reviewing this!! Is there anything more I need to do before this can get merged? (Just checking I haven't missed something obvious) |
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…n the AWS StsAssumeRoleCredentialsProvider (#11134) [HUDI-6695](https://issues.apache.org/jira/browse/HUDI-6695) added a AWS credentials provider to support assuming a role when syncing to Glue. We use Hudi in a multi-tenant environment, and our customers give us delegated access to their Glue catalog. In this multi-tenant setup it is important to use [an external ID](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html) to improve security when assuming IAM roles. Furthermore, the STS session name is currently hard-coded to "hoodie". It is helpful for us to have configurable session names so we have better tracability of what entities are creating STS sessions in the cloud. Currently, the assumed role is configured with the `hoodie.aws.role.arn` config property. I would like to add the following extra optional config properties, which will be used by the `HoodieConfigAWSAssumedRoleCredentialsProvider`: - `hoodie.aws.role.external.id` - `hoodie.aws.role.session.name`
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
…n the AWS StsAssumeRoleCredentialsProvider (#11134) [HUDI-6695](https://issues.apache.org/jira/browse/HUDI-6695) added a AWS credentials provider to support assuming a role when syncing to Glue. We use Hudi in a multi-tenant environment, and our customers give us delegated access to their Glue catalog. In this multi-tenant setup it is important to use [an external ID](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_create_for-user_externalid.html) to improve security when assuming IAM roles. Furthermore, the STS session name is currently hard-coded to "hoodie". It is helpful for us to have configurable session names so we have better tracability of what entities are creating STS sessions in the cloud. Currently, the assumed role is configured with the `hoodie.aws.role.arn` config property. I would like to add the following extra optional config properties, which will be used by the `HoodieConfigAWSAssumedRoleCredentialsProvider`: - `hoodie.aws.role.external.id` - `hoodie.aws.role.session.name`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
See issue HUDI-7699.
HUDI-6695 (#9260) added a AWS credentials provider to support assuming a role when syncing to Glue.
We use Hudi in a multi-tenant environment, and our customers give us delegated access to their Glue catalog. In this multi-tenant setup it is important to use an external ID to improve security when assuming IAM roles.
Furthermore, the STS session name is currently hard-coded to "hoodie". It is helpful for us to have configurable session names so we have better tracability of what entities are creating STS sessions in the cloud.
Currently, the assumed role is configured with the
hoodie.aws.role.arnconfig property. I would like to add the following extra optional config properties, which will be used by theHoodieConfigAWSAssumedRoleCredentialsProvider:hoodie.aws.role.external.idhoodie.aws.role.session.nameImpact
No impact to any existing way of using Hudi. It only adds more configurability to an existing feature.
Risk level (write none, low medium or high below)
Low
Documentation Update
None. The new configuration options need to be documented, but I believe that is done automatically from the config code (someone please confirm this!)
Contributor's checklist