-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-398]Add set env for spark launcher #1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
ca7e7be
4de8def
ba346ce
30d3250
b178c0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hudi.cli.commands; | ||
|
|
||
| import org.springframework.shell.core.CommandMarker; | ||
| import org.springframework.shell.core.annotation.CliCommand; | ||
| import org.springframework.shell.core.annotation.CliOption; | ||
| import org.springframework.stereotype.Component; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * CLI command to set env. | ||
| */ | ||
| @Component | ||
| public class SetSparkEnvCommand implements CommandMarker { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about renaming to SparkEnvCommand as it also supports show command? |
||
|
|
||
| public static Map env = new HashMap<String, String>(); | ||
|
|
||
| @CliCommand(value = "set", help = "Set spark launcher env to cli") | ||
| public void setEnv(@CliOption(key = {"conf"}, help = "Env config to be set") final String confMap) | ||
| throws IllegalArgumentException { | ||
| String[] map = confMap.split("="); | ||
| if (map.length != 2) { | ||
| throw new IllegalArgumentException("Illegal set parameter, please use like [set SPARK_HOME=/usr/etc/spark]'"); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove ' ?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it neccessary to support multi set in one batch such as set SPARK_HOME=/usr/etc/spark; set HADOOP_HOME=/usr/etc/hadoop? Or the changes only support set SPARK_HOME?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
All config is ok, forgot add |
||
| } | ||
| env.put(map[0].trim(), map[1].trim()); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to set and get env. ?