Skip to content

Conversation

@xicm
Copy link
Contributor

@xicm xicm commented Mar 18, 2024

Change Logs

#10097 we relocated "com.fasterxml.jackson.module",

hudi/pom.xml

Lines 582 to 586 in 2dcdd31

<relocation>
<pattern>com.fasterxml.jackson.module</pattern>
<shadedPattern>org.apache.hudi.com.fasterxml.jackson.module
</shadedPattern>
</relocation>

this changes the package path of jackson-module-scala_${scala.binary.version}.

When we do spark stream read, we will get ClassNotFoundException: org.apache.hudi.com.fasterxml.jackson.module.scala.DefaultScalaModule$

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Mar 18, 2024
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

<!-- afterburner module for jackson performance -->
<include>com.fasterxml.jackson.module:jackson-module-afterburner</include>
<include>com.fasterxml.jackson.module:jackson-module-scala_${scala.binary.version}</include>
<!-- native HFile reader uses protobuf -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @nsivabalan do we need to check other jackson related jars?

Copy link
Contributor

@CTTY CTTY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danny0405
Copy link
Contributor

@nsivabalan Can you check this PR?

@nsivabalan
Copy link
Contributor

yes, we might need to fix all bundles.
@ad1happy2go : can you try out the patch w/ spark and utilities bundle and let us know if we are good here.

@xicm
Copy link
Contributor Author

xicm commented Mar 25, 2024

I searched the whole project, only jackson-module-afterburner and jackson-module-scala have the package path "com.fasterxml.jackson.module". And the fix is in the main pom, this change also takes effect for other modules.

@danny0405
Copy link
Contributor

Would merge it first, we can fire following-up fix if it is necessary for specific bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants