Skip to content

Conversation

@geserdugarov
Copy link
Contributor

@geserdugarov geserdugarov commented Feb 29, 2024

Reverts commit 42799c0

Change Logs

Reverting of adding of unnecessary parameter hoodie.datasource.write.new.columns.nullable.

It started from issue 9042. The real problem was in inconsistency between Hudi table schema and Spark catalog schema. But during discussion of the issue JIRA task HUDI-6438 was created. As a results, the task was resolved by adding new parameter hoodie.datasource.write.new.columns.nullable, which is not right, because it allows to workaround implicit inconsistency in schemas. We need to provide consistency between existed schemas.

Furthermore, the real problem with inconsistency between Hudi table schema and Spark catalog schema was solved in another MR, which fixes similar former JIRA task HUDI-6219. This MR fix the issue properly. So, we don't need new parameter hoodie.datasource.write.new.columns.nullable.

Impact

Removes parameter, which allows to workaround implicit inconsistency in schemas.

Risk level (write none, low medium or high below)

Low

Documentation Update

Remove description of hoodie.datasource.write.new.columns.nullable from All Configurations list.
I will open corresponding MR to asf-site and link this MR.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

…llow for marking a newly created column as nullable."
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit bc522a6 into apache:master Mar 1, 2024
@geserdugarov geserdugarov deleted the HUDI-6438-revert branch March 1, 2024 04:54
yihua pushed a commit that referenced this pull request May 14, 2024
…llow for marking a newly created column as nullable." (#10782)
yihua pushed a commit that referenced this pull request May 14, 2024
…llow for marking a newly created column as nullable." (#10782)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants