[MINOR] Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test #10526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Collaborator
KnightChess
reviewed
Jan 21, 2024
|
|
||
| // Since the concurrent modifications went in, this upsert has | ||
| // to fail | ||
| // Note: the start time of upsert must be smaller than the compaction scheduling time |
Contributor
There was a problem hiding this comment.
hi, why this upsert commit must be smaller than compaction scheduling time, can you describe the problem in detail.
Contributor
|
Hi, @Zouxxyy , can you clarify the review comments and we are good to land. |
Contributor
|
This fix is related to HUDI-7483. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test
Impact
Fix flaky testMultiWriterWithAsyncTableServicesWithConflict test
Risk level (write none, low medium or high below)
none
Documentation Update
none
Contributor's checklist