Skip to content

[HUDI-362] Adds a check for the existence of field #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinothchandar merged 1 commit into from
Nov 25, 2019
Merged

[HUDI-362] Adds a check for the existence of field #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hudi-cli/src/main/java/org/apache/hudi/cli/HoodiePrintHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ public static String print(TableHeader rowHeader, Map<String, Function<Object, S
return HoodiePrintHelper.print(rowHeader);
}

if (!sortByField.isEmpty() && !rowHeader.containsField(sortByField)) {
return String.format("Field[%s] is not in table, given columns[%s]", sortByField, rowHeader.getFieldNames());
}

Table table =
new Table(rowHeader, fieldNameToConverterMap, Option.ofNullable(sortByField.isEmpty() ? null : sortByField),
Option.ofNullable(isDescending), Option.ofNullable(limit <= 0 ? null : limit)).addAllRows(rows).flip();
Expand Down
4 changes: 4 additions & 0 deletions hudi-cli/src/main/java/org/apache/hudi/cli/TableHeader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,8 @@ public String get(int index) {
public int getNumFields() {
return fieldNames.size();
}

public boolean containsField(String fieldName) {
return fieldNames.contains(fieldName);
}
}