[HUDI-7040] Handle dropping of partition columns with populate meta fields disabled #10272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
reviewed
Dec 7, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Thanks for the fix! Left some comments. Can you also check the CI failures?
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
Show resolved
Hide resolved
...nt/src/main/java/org/apache/hudi/table/action/commit/BulkInsertDataInternalWriterHelper.java
Outdated
Show resolved
Hide resolved
...-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala
Outdated
Show resolved
Hide resolved
...-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala
Show resolved
Hide resolved
bhat-vinay
force-pushed
the
HUDI-7040-fix-drop-partition-columns
branch
from
70388e7 to
9e4cc4f
Compare
Contributor
Author
|
Thanks for the comments @codope. Addressed comments. |
codope
changed the title
codope
reviewed
Dec 11, 2023
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/TestHoodieSparkSqlWriter.scala
Outdated
Show resolved
Hide resolved
...-client/hudi-spark-client/src/main/scala/org/apache/hudi/HoodieDatasetBulkInsertHelper.scala
Outdated
Show resolved
Hide resolved
…ernalWriterHelper::write(...) Issue: There are two configs which when set in a certain manner throws exceptions or asserts 1. Configs to disable populating metadata fields (for each row) 2. Configs to drop partition columns (to save storage space) from a row With apache#1 and apache#2, partition paths cannot be deduced using partition columns (as the partition columns are dropped higher up the stack. BulkInsertDataInternalWriterHelper::write(...) relied on metadata fields to extract partition path in such cases. But with apache#1 it is not possible resulting in asserts/exceptions. The fix is to push down the dropping of partition columns down the stack after partition path is computed. The fix manipulates the raw 'InternalRow' row structure by only copying the relevent fields into a new 'InternalRow' structure. Each row is processed individually to drop the partition columns and copy it a to new 'InternalRow'
bhat-vinay
force-pushed
the
HUDI-7040-fix-drop-partition-columns
branch
from
9e4cc4f to
3827b7b
Compare
codope
approved these changes
Dec 11, 2023
Member
codope
left a comment
codope
left a comment
There was a problem hiding this comment.
Looks good. Can land once the CI is green.
Collaborator
nsivabalan
pushed a commit
that referenced
this pull request
Dec 18, 2023
…ernalWriterHelper::write(...) (#10272) Issue: There are two configs which when set in a certain manner throws exceptions or asserts 1. Configs to disable populating metadata fields (for each row) 2. Configs to drop partition columns (to save storage space) from a row With #1 and #2, partition paths cannot be deduced using partition columns (as the partition columns are dropped higher up the stack. BulkInsertDataInternalWriterHelper::write(...) relied on metadata fields to extract partition path in such cases. But with #1 it is not possible resulting in asserts/exceptions. The fix is to push down the dropping of partition columns down the stack after partition path is computed. The fix manipulates the raw 'InternalRow' row structure by only copying the relevent fields into a new 'InternalRow' structure. Each row is processed individually to drop the partition columns and copy it a to new 'InternalRow' Co-authored-by: Vinaykumar Bhat <[email protected]>
| def testBulkInsertForDropPartitionColumn(): Unit = { | ||
| //create a new table | ||
| val tableName = "trips_table" | ||
| val basePath = "file:///tmp/trips_table" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixes #9991
Issue:
There are two configs which when set in a certain manner throws exceptions or asserts
With 1 and 2 above, partition paths cannot be deduced using partition columns (as the partition columns are dropped higher up the stack.
BulkInsertDataInternalWriterHelper::write(...)relied on metadata fields to extract partition path in such cases. But with only 1 it is not possible resulting in asserts/exceptions.The fix is to push down the dropping of partition columns down the stack after partition path is computed. The fix manipulates the raw 'InternalRow' row structure by only copying the relevent fields into a new 'InternalRow' structure. Each row is processed individually to drop the partition columns and copy it a to new 'InternalRow'
Impact
No piblic API or user facing changes. However, each
InternalRowstructure is processed and copied individually whenthe config is set.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist