-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[HUDI-342] add pull request template for hudi project #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| ## *Tips* | ||
| - *Thank you very much for contributing to Apache Hudi.* | ||
| - *Please review https://hudi.apache.org/contributing.html before opening a pull request.* | ||
|
|
||
| ## What is the purpose of the pull request | ||
|
|
||
| *(For example: This pull request adds quick-start document.)* | ||
|
|
||
| ## Brief change log | ||
|
|
||
| *(for example:)* | ||
| - *Modify AnnotationLocation checkstyle rule in checkstyle.xml* | ||
|
|
||
| ## Verify this pull request | ||
|
|
||
| *(Please pick either of the following options)* | ||
|
|
||
| This pull request is a trivial rework / code cleanup without any test coverage. | ||
|
|
||
| *(or)* | ||
|
|
||
| This pull request is already covered by existing tests, such as *(please describe tests)*. | ||
|
|
||
| (or) | ||
|
|
||
| This change added tests and can be verified as follows: | ||
|
|
||
| *(example:)* | ||
|
|
||
| - *Added integration tests for end-to-end.* | ||
| - *Added HoodieClientWriteTest to verify the change.* | ||
| - *Manually verified the change by running a job locally.* | ||
|
|
||
| ## Committer checklist | ||
|
|
||
| - [ ] Has a corresponding JIRA in PR title & commit | ||
|
|
||
| - [ ] Commit message is descriptive of the change | ||
|
|
||
| - [ ] CI is green | ||
|
|
||
| - [ ] Necessary doc changes done or have another open PR | ||
|
|
||
| - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.