Skip to content

[HUDI-7119]Don't write hoodie.table.precombine.field=ts to hoodie.properties when use Flink to create a insert hudi table and the ts field does not exist #10133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Nov 19, 2023
Merged

[HUDI-7119]Don't write hoodie.table.precombine.field=ts to hoodie.properties when use Flink to create a insert hudi table and the ts field does not exist #10133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,8 @@ private void sanityCheck(Configuration conf, ResolvedSchema schema) {

if (!OptionsResolver.isAppendMode(conf)) {
checkRecordKey(conf, schema);
checkPreCombineKey(conf, schema);
}
checkPreCombineKey(conf, schema);
}

/**
Expand Down
9 changes: 9 additions & 0 deletions ...ink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/TestHoodieTableFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,9 @@ void testRequiredOptions() {
final MockContext sourceContext11 = MockContext.getInstance(this.conf, schema1, "f2");
assertDoesNotThrow(() -> new HoodieTableFactory().createDynamicTableSource(sourceContext11));
assertDoesNotThrow(() -> new HoodieTableFactory().createDynamicTableSink(sourceContext11));
//miss the pre combine key will be ok
HoodieTableSink tableSink11 = (HoodieTableSink) new HoodieTableFactory().createDynamicTableSink(sourceContext11);
assertThat(tableSink11.getConf().getString(FlinkOptions.PRECOMBINE_FIELD), is(FlinkOptions.NO_PRE_COMBINE));
this.conf.set(FlinkOptions.OPERATION, FlinkOptions.OPERATION.defaultValue());

// a non-exists precombine key will throw exception
Expand Down Expand Up @@ -140,6 +143,12 @@ void testRequiredOptions() {
assertThat(tableSource.getConf().getString(FlinkOptions.PAYLOAD_CLASS_NAME), is(FlinkOptions.PAYLOAD_CLASS_NAME.defaultValue()));
assertThat(tableSink.getConf().getString(FlinkOptions.PAYLOAD_CLASS_NAME), is(FlinkOptions.PAYLOAD_CLASS_NAME.defaultValue()));

// append mode given the pk but miss the pre combine key will be ok
this.conf.set(FlinkOptions.OPERATION, "insert");
HoodieTableSink tableSink3 = (HoodieTableSink) new HoodieTableFactory().createDynamicTableSink(sourceContext3);
assertThat(tableSink3.getConf().getString(FlinkOptions.PRECOMBINE_FIELD), is(FlinkOptions.NO_PRE_COMBINE));
this.conf.set(FlinkOptions.OPERATION, FlinkOptions.OPERATION.defaultValue());

this.conf.setString(FlinkOptions.PAYLOAD_CLASS_NAME, DefaultHoodieRecordPayload.class.getName());
final MockContext sourceContext4 = MockContext.getInstance(this.conf, schema3, "f2");

Expand Down