[HUDI-7088] convert avro logical timestamp types correctly #10079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Note to myself: Add tests. |
Collaborator
nsivabalan
added
priority:critical
Contributor
|
hey @jonvex : can you review the patch |
Contributor
jonvex
requested changes
Nov 15, 2023
Contributor
jonvex
left a comment
jonvex
left a comment
There was a problem hiding this comment.
https://mvnrepository.com/artifact/org.apache.spark/spark-core_2.12/3.1.3
https://avro.apache.org/docs/1.10.2/spec.html#Local+timestamp+%28millisecond+precision%29
spark 3.1 and below don't support this. You should use the spark adapter for version specific code
xushiyan
reviewed
Nov 16, 2023
Comment on lines
-79
to
+80
| case _: TimestampMillis | _: TimestampMicros => SchemaType(TimestampType, nullable = false) | ||
| case _: TimestampMillis | _: TimestampMicros | _: LocalTimestampMillis | _: LocalTimestampMicros | ||
| => SchemaType(TimestampType, nullable = false) |
Member
There was a problem hiding this comment.
make sure to extend an existing UT to cover this? or start a new one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Fix bug to correct avro logical timestamp conversion to account for local-timestamp (millisecond precision and microsecond precision).
Impact
Spark datasource reads will reflect timestamp types instead of longs for the types fixed.
Risk level (write none, low medium or high below)
Low
Documentation Update
N/A
Contributor's checklist