Skip to content

[MINOR] Add detailed error logs in RunCompactionProcedure #10070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 2 commits into from
Nov 15, 2023
Merged

[MINOR] Add detailed error logs in RunCompactionProcedure #10070

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0057c5
[MINOR] Add detailed error logs in RunCompactionProcedure
beyond1920 Nov 12, 2023
4cd917b
only print 100 error file paths into logs
beyond1920 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .../src/main/scala/org/apache/spark/sql/hudi/command/procedures/RunCompactionProcedure.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,15 @@ class RunCompactionProcedure extends BaseProcedure with ProcedureBuilder with Sp

private def handleResponse(metadata: HoodieCommitMetadata): Unit = {
// Handle error
val writeStats = metadata.getPartitionToWriteStats.entrySet().flatMap(e => e.getValue).toList
val errorsCount = writeStats.map(state => state.getTotalWriteErrors).sum
if (errorsCount > 0) {
throw new HoodieException(s" Found $errorsCount when writing record")
val writeStatsHasErrors = metadata.getPartitionToWriteStats.entrySet()
.flatMap(e => e.getValue)
.filter(_.getTotalWriteErrors > 0)
if (writeStatsHasErrors.nonEmpty) {
val errorsCount = writeStatsHasErrors.map(_.getTotalWriteErrors).sum
log.error(s"Found $errorsCount when writing record.\n Printing out the top 100 file path with errors.")
writeStatsHasErrors.take(100).foreach(state =>
log.error(s"Error occurred while writing the file: ${state.getPath}."))
throw new HoodieException(s"Found $errorsCount when writing record")
}
}

Expand Down