Skip to content
3 changes: 3 additions & 0 deletions crates/core/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ pub enum CoreError {
#[error("Timeline error: {0}")]
Timeline(String),

#[error("{0}")]
TimestampParsingError(String),

#[error("{0}")]
Unsupported(String),

Expand Down
19 changes: 13 additions & 6 deletions crates/core/src/table/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
mod listing;
pub mod partition;

use crate::config::read::HudiReadConfig;
use crate::config::table::HudiTableConfig::PartitionFields;
use crate::config::table::{HudiTableConfig, TableTypeValue};
use crate::config::HudiConfigs;
Expand All @@ -101,10 +102,9 @@
use crate::table::builder::TableBuilder;
use crate::table::fs_view::FileSystemView;
use crate::table::partition::PartitionPruner;
use crate::timeline::util::format_timestamp;
use crate::timeline::{Timeline, EARLIEST_START_TIMESTAMP};
use crate::Result;

use crate::config::read::HudiReadConfig;
use arrow::record_batch::RecordBatch;
use arrow_schema::{Field, Schema};
use std::collections::{HashMap, HashSet};
Expand Down Expand Up @@ -330,8 +330,9 @@
I: IntoIterator<Item = (S, S, S)>,
S: AsRef<str>,
{
let timestamp = format_timestamp(timestamp, &self.timezone())?;
let filters = from_str_tuples(filters)?;
self.get_file_slices_splits_internal(n, timestamp, &filters)
self.get_file_slices_splits_internal(n, &timestamp, &filters)

Check warning on line 335 in crates/core/src/table/mod.rs

View check run for this annotation

Codecov / codecov/patch

crates/core/src/table/mod.rs#L335

Added line #L335 was not covered by tests
.await
}

Expand Down Expand Up @@ -424,8 +425,9 @@
I: IntoIterator<Item = (S, S, S)>,
S: AsRef<str>,
{
let timestamp = format_timestamp(timestamp, &self.timezone())?;
let filters = from_str_tuples(filters)?;
self.get_file_slices_internal(timestamp, &filters).await
self.get_file_slices_internal(&timestamp, &filters).await

Check warning on line 430 in crates/core/src/table/mod.rs

View check run for this annotation

Codecov / codecov/patch

crates/core/src/table/mod.rs#L430

Added line #L430 was not covered by tests
}

/// Same as [Table::get_file_slices_as_of], but blocking.
Expand Down Expand Up @@ -587,8 +589,9 @@
I: IntoIterator<Item = (S, S, S)>,
S: AsRef<str>,
{
let timestamp = format_timestamp(timestamp, &self.timezone())?;
let filters = from_str_tuples(filters)?;
self.read_snapshot_internal(timestamp, &filters).await
self.read_snapshot_internal(&timestamp, &filters).await

Check warning on line 594 in crates/core/src/table/mod.rs

View check run for this annotation

Codecov / codecov/patch

crates/core/src/table/mod.rs#L594

Added line #L594 was not covered by tests
}

/// Same as [Table::read_snapshot_as_of], but blocking.
Expand Down Expand Up @@ -643,8 +646,12 @@
return Ok(Vec::new());
};

let timezone = self.timezone();
let start_timestamp = format_timestamp(start_timestamp, &timezone)?;
let end_timestamp = format_timestamp(end_timestamp, &timezone)?;

let file_slices = self
.get_file_slices_between_internal(start_timestamp, end_timestamp)
.get_file_slices_between_internal(&start_timestamp, &end_timestamp)
.await?;

let fg_reader = self.create_file_group_reader_with_options([
Expand Down
1 change: 1 addition & 0 deletions crates/core/src/timeline/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
pub mod instant;
pub(crate) mod selector;
pub(crate) mod util;

use crate::config::HudiConfigs;
use crate::error::CoreError;
Expand Down
Loading
Loading