Skip to content

Conversation

@messense
Copy link
Member

@messense messense commented Jul 29, 2022

Fixes #20

@messense messense marked this pull request as draft July 29, 2022 02:50
@ShiKaiWi
Copy link
Member

ShiKaiWi commented Aug 3, 2022

@messense All the checks pass already except that style check reports error: license check failed.

@messense messense marked this pull request as ready for review August 4, 2022 02:04
@messense messense changed the title Test cmake cross compiling fix fix: cmake cross compiling fix for arm64 macOS Aug 4, 2022
@waynexia waynexia requested a review from ShiKaiWi August 4, 2022 06:05
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@messense Thanks a lot for fixing such a tough issue.

@ShiKaiWi ShiKaiWi merged commit 5a63f4e into apache:main Aug 5, 2022
@messense messense deleted the cmake branch August 5, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

arm64 macOS wheel is broken

2 participants