HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259

ramitg254 · 2026-01-07T13:00:42Z

…for Iceberg table

What changes were proposed in this pull request?

Adds support for using partition spec with describe statement for iceberg table.
and updated the other test outputs as partition information is also gettting printed for desc statement after the changes

Why are the changes needed?

currently using partition spec with describe statement for iceberg table result in unsupported exception

Does this PR introduce any user-facing change?

yes, this statement will not result in exception anymore

How was this patch tested?

build locally and ci tests and added q tests

…for Iceberg table

kokila-19 · 2026-01-13T19:25:30Z

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java

    return null;
  }
+
+  private Partition getPartition(Table tab, Map<String, String> partitionSpec) throws HiveException {


The logic here is almost same as getPartition() in DescTableOperation.java https://github.com/apache/hive/pull/6259/changes#diff-641c62b42b01bff41c89a3b3661c15d6c08fce0e48740347f36fe32448984147R131

Check if you can add them in an utility so it can be reused

Thanks for checking it, moved out this logic from DescTableOperation.java and DescTableAnalyzer.java to HiveIcebergStorageHandler.java
https://github.com/apache/hive/pull/6259/changes#diff-93864ecf035fe51b92185015da842a56837cea89064813de39c278c6f8fed03cR2079
please take a look

soumyakanti3578

DDLUtils.isIcebergTable() has been used in many places in the compiler. I think we should not use a specific table type here.

soumyakanti3578 · 2026-01-13T23:30:26Z

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java

  }
+
+  private Partition getPartition(Table tab, Map<String, String> partitionSpec) throws HiveException {
+    boolean isIcebergTable = DDLUtils.isIcebergTable(tab);


Please don't use DDLUtils.isIcebergTable as this API in the compiler is too specific. Instead please use tab.isNonNative() in conjunction to other APIs if needed.

Thanks for checking it, tried to make changes more generic to non native tables instead of iceberg centric please take a look

@ramitg254, consider joining with Table.hasNonNativePartitionSupport

deniskuzZ · 2026-01-15T13:39:52Z

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableAnalyzer.java

        try {
-          part = db.getPartition(tab, partitionSpec, false);
+          isPartitionPresent = table.isNonNative() ?
+                  table.getStorageHandler().isPartitionPresent(table, partitionSpec) :


can we keep the original code

part = db.getPartition(tab, partitionSpec)

and return null in StorageHandler.getPartition when partition doesn't exist?

actually I intentionally dropped the original code there as getPartition is called at two places one is in analyzer and other is in operation and this is check uses two lists via getPartitions and getPartitionKeys and if I move this check to getPartition then this check will be called two times
But in the current state we are calling it single time only in analyzer phase and retrieving the partition directly in operation phase which I think is more efficient

sorry, i didn't catch the idea. please see comment in #6259 (comment)

done, kept the original one

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/formatter/TextDescTableFormatter.java

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java

ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java

deniskuzZ · 2026-01-15T13:53:38Z

ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java

    return false;
  }

+  default boolean isPartitionPresent(org.apache.hadoop.hive.ql.metadata.Table table,


actually I added it because of these considerations:

getPartition in iceberg returns dummy partition corresponding to that partSpec without checking it is already present or not and this functionality is used in other places like for insert queries for iceberg tables as well that's why I added this separate method

I also thought of adding this method in Hive.java instead of storage handler but that would be too specific and if we have newer storage handler in future then it can have some different implementation to check the partition is present or not

getPartition in iceberg returns dummy partition corresponding to that partSpec without checking it is already present or not

exactly. i think we need to change that API and also drop the RewritePolicy policy arg (move Context.RewritePolicy.get(conf) inside the StorageHandler).
getPartition() should return dummy partition corresponding to the provided partSpec only if exists otherwise it confusing.

please check if ATM this method is only used by Iceberg compaction. in that scenario we could skip the validation (i.e. check for SessionState.get().isCompaction())
cc @difin

@deniskuzZ updated the getPartition api implementation as per the suggestion and tests are passing without affecting any insertion and compaction related queries. Please have a look

deniskuzZ · 2026-01-15T13:54:35Z

iceberg/iceberg-handler/src/test/queries/negative/desc_ice_tbl_partial_part_spec.q

@@ -0,0 +1,4 @@
+drop table if exists ice_t;


please combine it with the desc_ice_tbl_part_spec.q

can you please explain what do you mean by combining ?

please keep both test cases in 1 qfile

sonarqubecloud · 2026-01-16T16:24:17Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

asf-ci-hive added tests pending tests unstable and removed tests pending tests unstable labels Jan 7, 2026

ramitg254 force-pushed the HIVE-29376 branch from 562a7ae to b7c1df6 Compare January 8, 2026 16:56

asf-ci-hive added tests pending tests failed and removed tests unstable tests pending labels Jan 8, 2026

HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported …

a8204f5

…for Iceberg table

ramitg254 force-pushed the HIVE-29376 branch from b7c1df6 to a8204f5 Compare January 8, 2026 17:21

asf-ci-hive added tests pending and removed tests failed labels Jan 8, 2026

ramitg254 changed the title ~~[WIP]HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported …~~ HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … Jan 8, 2026

asf-ci-hive added tests passed and removed tests pending labels Jan 8, 2026

addressed sonar issues

a32a9b8

asf-ci-hive added tests pending tests failed tests passed and removed tests passed tests pending tests failed labels Jan 9, 2026

kokila-19 reviewed Jan 13, 2026

View reviewed changes

soumyakanti3578 requested changes Jan 13, 2026

View reviewed changes

ramitg254 force-pushed the HIVE-29376 branch from 56ea49a to 0af4f62 Compare January 14, 2026 16:40

asf-ci-hive added tests unstable tests pending tests passed and removed tests pending tests unstable labels Jan 14, 2026

deniskuzZ reviewed Jan 15, 2026

View reviewed changes

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/formatter/TextDescTableFormatter.java Outdated Show resolved Hide resolved

deniskuzZ reviewed Jan 15, 2026

View reviewed changes

ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/desc/DescTableOperation.java Show resolved Hide resolved

deniskuzZ reviewed Jan 15, 2026

View reviewed changes

ql/src/java/org/apache/hadoop/hive/ql/metadata/DummyPartition.java Outdated Show resolved Hide resolved

deniskuzZ reviewed Jan 15, 2026

View reviewed changes

used hasNonNativePartitionSupport() in place of isNonNative()

d32c626

asf-ci-hive added tests pending tests passed and removed tests passed tests pending labels Jan 16, 2026

ramitg254 force-pushed the HIVE-29376 branch from d0763a0 to 84cdb31 Compare January 16, 2026 12:01

asf-ci-hive added tests pending tests unstable and removed tests passed tests pending labels Jan 16, 2026

updated getPartition Api

4f9622a

ramitg254 force-pushed the HIVE-29376 branch from 84cdb31 to 4f9622a Compare January 16, 2026 15:15

asf-ci-hive added tests pending and removed tests unstable labels Jan 16, 2026

asf-ci-hive added tests passed and removed tests pending labels Jan 16, 2026

HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259

Are you sure you want to change the base?

HIVE-29376:Using partition spec in DESC FORMATTED sql is unsupported … #6259

Conversation

ramitg254 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soumyakanti3578 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deniskuzZ Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deniskuzZ Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 16, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ramitg254 commented Jan 7, 2026 •

edited

Loading

deniskuzZ Jan 15, 2026 •

edited

Loading

deniskuzZ Jan 16, 2026 •

edited

Loading