HIVE-28886: CalcitePlanner throws NullPointerException when column name case in ColumnStatisticsObj differs from the table schema #5763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me case in ColumnStatisticsObj differs from the table schema
aturoczy
reviewed
Apr 10, 2025
| List<Object> values) throws HiveException { | ||
| ColumnStatisticsObj statsObj = new ColumnStatisticsObj(); | ||
| statsObj.setColName(columnName); | ||
| statsObj.setColName(columnName.toLowerCase()); |
There was a problem hiding this comment.
How this fix the lower case? Somewhere is a compare the column name and in other places could be capital?
Member
Author
There was a problem hiding this comment.
it's always lowercased in Hive schema, but not in ColumnStatisticsObj
aturoczy
approved these changes
Apr 10, 2025
SourabhBadhya
approved these changes
Apr 10, 2025
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
tests failed
labels
|
kasakrisz
reviewed
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Transform the column name in ColumnStatsObj to lowercase
Why are the changes needed?
NullPointerException Fix
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
q test