Skip to content

HIVE-28866: Upgrade netty-codec-http to fix CVE-2024-29025 #5736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanishq-chugh wants to merge 3 commits into from
Closed

HIVE-28866: Upgrade netty-codec-http to fix CVE-2024-29025 #5736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5b7217
HIVE-28866: Upgrade netty-codec-http to fix CVE-2024-29025
tanishq-chugh Apr 2, 2025
bd96998
Remove old netty transitive versions by adding required deps in depen…
tanishq-chugh Apr 2, 2025
bec5c85
Try upgrading netty to 4.1.119.Final
tanishq-chugh Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@
<mockito-core.version>3.4.4</mockito-core.version>
<mockito-inline.version>4.11.0</mockito-inline.version>
<mina.version>2.0.0-M5</mina.version>
<netty.version>4.1.116.Final</netty.version>
<netty.version>4.1.119.Final</netty.version>
<netty3.version>3.10.5.Final</netty3.version>
<!-- used by druid storage handler -->
<pac4j-saml.version>4.5.8</pac4j-saml.version>
Expand Down Expand Up @@ -430,6 +430,16 @@
<artifactId>netty-all</artifactId>
<version>${netty.version}</version>
</dependency>
<dependency>
Copy link
Member

@ayushtkn ayushtkn Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding dependency is scope of upgrade? I don't see any exclusions either which could lead it this?

Copy link
Contributor Author

@tanishq-chugh tanishq-chugh Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding these specifications in dependencyManagement, coz other deps were bringing in older versions of these transitively and with this addition we'll get only 4.1.119.Final.
We are addressing @Aggarwal-Raghav comment with this #5736 (comment)

Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are adding these specifications in dependencyManagement, coz other deps were bringing in older versions of these transitively and with this addition we'll get only 4.1.119.Final. We are addressing @Aggarwal-Raghav comment with this #5736 (comment)

@tanishq-chugh , can you please provide the sonatype report URL for this? I don't see netty-codec-http coming up in my nexus scan in my org.
Regarding this approach to add dependency of higher version is not a good idea, IMO, because if higher version of netty is not backward compatible with older version (required by transitive dependency) then we are prone to NoSuchMethod or NoClassFound errors at runtime. This is similar to the avro issue #5593 that we last discussed.

<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
<version>${netty.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<version>${netty.version}</version>
</dependency>
<dependency>
<groupId>jakarta.jms</groupId>
<artifactId>jakarta.jms-api</artifactId>
Expand Down
16 changes: 16 additions & 0 deletions standalone-metastore/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@
<libthrift.version>0.16.0</libthrift.version>
<log4j2.version>2.24.3</log4j2.version>
<mockito-core.version>3.4.4</mockito-core.version>
<netty.version>4.1.119.Final</netty.version>
<orc.version>1.9.4</orc.version>
<protobuf.version>3.25.5</protobuf.version>
<io.grpc.version>1.51.0</io.grpc.version>
Expand Down Expand Up @@ -173,6 +174,21 @@
<artifactId>metrics-json</artifactId>
<version>${dropwizard.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-all</artifactId>
Copy link
Contributor

@Aggarwal-Raghav Aggarwal-Raghav Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the goal is for the transitive dependencies to have higher version of netty?

Also, I see older version of netty (can be seen in your attached dependency tree) in packaging/target/apache-hive-4.1.0-SNAPSHOT-bin/apache-hive-4.1.0-SNAPSHOT-bin/lib coming from zookeeper 3.8.4 and has CVE's as well https://mvnrepository.com/artifact/io.netty/netty-handler/4.1.105.Final

netty-handler-4.1.105.Final.jar
netty-transport-native-epoll-4.1.105.Final.jar

Copy link
Contributor Author

@tanishq-chugh tanishq-chugh Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added these deps as well in dependencyManagement in bd96998 , so these transitive dependencies are of the same versions.

<version>${netty.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
<version>${netty.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-transport-native-epoll</artifactId>
<version>${netty.version}</version>
</dependency>
<dependency>
<groupId>javolution</groupId>
<artifactId>javolution</artifactId>
Expand Down
Loading