HIVE-28759: Hive Query History - records are failed to be written due to iceberg worker pools shut down #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to iceberg worker pools shut down Change-Id: I0baacca4020241e2cf892990f246da0adccf253b
abstractdog
force-pushed
the
HIVE-28759
branch
from
a738d7f to
140bf92
Compare
asf-ci-hive
added
tests failed
tests pending
and removed
tests pending
tests failed
labels
|
deniskuzZ
reviewed
Feb 18, 2025
|
|
||
| int poolSize = getIcebergWorkerPoolSize(); | ||
| LOG.info("Overriding iceberg worker pool, size: {}", poolSize); | ||
| field.set(null, Executors.newFixedThreadPool(poolSize, |
There was a problem hiding this comment.
this is a hack! we shouldn't touch iceberg-worker-pool just for the sake of query history.
There was a problem hiding this comment.
totally understand your concern
do you think this is something to work on the iceberg side? I mean, iceberg worker pool allows tasks to finish 120s after the shutdown, but doesn't let any tasks be submitted, which is very unfortunate (we have quite short tasks here to flush the leftover records, just cannot make it happen)
so the problem is theoretically with the hack itself or the fact I'm trying to submit a task in a shutdown hook in hs2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Replaces iceberg's worker thread pool with a same-sized one that accepts tasks after jvm shutdown hook.
Why are the changes needed?
Described on jira, tldr, to make query history able to flush records on hs2 shutdown.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Manually tested on local MiniHS2 and Cloudera Data Warehouse, the HS2 showed that the full commit process ran successfully. Without the patch, the RejectedExecutionException was present in both scenarios.