-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28751: Upgrade curator version from 5.2.0 to 5.7.1 to fix CVE-2023-2976 #5640
Conversation
@okumin Could you please review this? Thank you. |
Occurences of older curator-client-5.2.0.jar have been updated with the upgraded version: located at packaging/target/apache-hive-4.0.0.3.4.0-SNAPSHOT-bin.tar.gz/apache-hive-4.0.0.3.4.0-SNAPSHOT-bin/lib located at standalone-metastore/metastore-server/target/apache-hive-standalone-metastore-server-4.0.0.3.4.0-SNAPSHOT-bin.tar.gz/apache-hive-metastore-4.0.0.3.4.0-SNAPSHOT-bin/lib Our current version of ZK is 3.8.4 which lies in the specified range and so is compatible with curator 5.6.0 |
I compared the diff between the parent revision(35589d7) and this branch. All are expected
|
e760de3
to
342d643
Compare
The latest diff % diff /tmp/before.txt /tmp/after.txt
893,906c893,906
< [INFO] org.apache.curator:apache-curator:pom:5.2.0:compile
< [INFO] org.apache.curator:apache-curator:pom:5.2.0:provided
< [INFO] org.apache.curator:apache-curator:pom:5.2.0:test
< [INFO] org.apache.curator:curator-client:jar:5.2.0:compile -- module curator.client (auto)
< [INFO] org.apache.curator:curator-client:jar:5.2.0:provided -- module curator.client (auto)
< [INFO] org.apache.curator:curator-client:jar:5.2.0:test -- module curator.client (auto)
< [INFO] org.apache.curator:curator-framework:jar:5.2.0:compile -- module curator.framework (auto)
< [INFO] org.apache.curator:curator-framework:jar:5.2.0:provided -- module curator.framework (auto)
< [INFO] org.apache.curator:curator-framework:jar:5.2.0:test -- module curator.framework (auto)
< [INFO] org.apache.curator:curator-recipes:jar:5.2.0:compile -- module curator.recipes (auto)
< [INFO] org.apache.curator:curator-recipes:jar:5.2.0:provided -- module curator.recipes (auto)
< [INFO] org.apache.curator:curator-recipes:jar:5.2.0:runtime -- module curator.recipes (auto)
< [INFO] org.apache.curator:curator-recipes:jar:5.2.0:test -- module curator.recipes (auto)
< [INFO] org.apache.curator:curator-test:jar:5.2.0:test -- module curator.test (auto)
---
> [INFO] org.apache.curator:apache-curator:pom:5.7.1:compile
> [INFO] org.apache.curator:apache-curator:pom:5.7.1:provided
> [INFO] org.apache.curator:apache-curator:pom:5.7.1:test
> [INFO] org.apache.curator:curator-client:jar:5.7.1:compile -- module curator.client (auto)
> [INFO] org.apache.curator:curator-client:jar:5.7.1:provided -- module curator.client (auto)
> [INFO] org.apache.curator:curator-client:jar:5.7.1:test -- module curator.client (auto)
> [INFO] org.apache.curator:curator-framework:jar:5.7.1:compile -- module curator.framework (auto)
> [INFO] org.apache.curator:curator-framework:jar:5.7.1:provided -- module curator.framework (auto)
> [INFO] org.apache.curator:curator-framework:jar:5.7.1:test -- module curator.framework (auto)
> [INFO] org.apache.curator:curator-recipes:jar:5.7.1:compile -- module curator.recipes (auto)
> [INFO] org.apache.curator:curator-recipes:jar:5.7.1:provided -- module curator.recipes (auto)
> [INFO] org.apache.curator:curator-recipes:jar:5.7.1:runtime -- module curator.recipes (auto)
> [INFO] org.apache.curator:curator-recipes:jar:5.7.1:test -- module curator.recipes (auto)
> [INFO] org.apache.curator:curator-test:jar:5.7.1:test -- module curator.test (auto) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
TODO
- Wait for CI and 24 hours
- Update the title of this PR
- Update the title of the JIRA ticket
342d643
to
d9ba2e3
Compare
|
The CI is green now. Updated titles. |
What changes were proposed in this pull request?
Upgrade curator.version in pom.xml from 5.2.0 to 5.7.1
CVE mentioned in mvn repo: CVE-2023-2976
Why are the changes needed?
HIVE-28751
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
Yes
tree.txt
How was this patch tested?
mvn dependency:tree