HIVE-28749: The default hikaricp.leakDetectionThreshold is not valid #5639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dengzhhu653
reviewed
Feb 10, 2025
...er/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
zabetak
approved these changes
Feb 11, 2025
...er/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java
Show resolved
Hide resolved
...er/src/main/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java
Outdated
Show resolved
Hide resolved
okumin
commented
Feb 11, 2025
| Properties properties = replacePrefix( | ||
| DataSourceProvider.getPrefixedProperties(hdpConfig, HIKARI)); | ||
| long connectionTimeout = hdpConfig.getLong(CONNECTION_TIMEOUT_PROPERTY, 30000L); | ||
| long leakDetectionThreshold = hdpConfig.getLong(LEAK_DETECTION_THRESHOLD, 3600000L); |
There was a problem hiding this comment.
As a new unit test explains, the default connection timeout is originally 30 seconds.
We also decided to use the default leak detection threshold. It doesn't change the behavior because the current value is invalid, and the detection is disabled.
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
dengzhhu653
approved these changes
Feb 12, 2025
asf-ci-hive
added
tests pending
tests unstable
tests failed
and removed
tests failed
tests pending
tests unstable
labels
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
HicariConfig's leak detection threshold has to be smaller than the max lifetime. Our default leak detection threshold is greater than the maximum lifetime defined on the HikariCP side and is disabled by default. Please check the JIRA for details.
https://issues.apache.org/jira/browse/HIVE-28749
Why are the changes needed?
Make our default value effective.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
hikaricp.maxLifetimewas configurable in my local machine