HIVE-28727: Iceberg: Refactor IcebergTableUtil.toPartitionData #5622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okumin
force-pushed
the
HIVE-28727-compaction-null
branch
from
31896b5 to
97772fc
Compare
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
okumin
force-pushed
the
HIVE-28727-compaction-null
branch
2 times, most recently
from
fc37361 to
dd1c930
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
okumin
commented
Jan 26, 2025
| {"company_id":100,"dept_id":1,"team_id":null} 1 0 3 | ||
| {"company_id":100,"dept_id":2,"team_id":null} 1 0 3 | ||
| {"company_id":null,"dept_id":null,"team_id":null} 1 0 1 | ||
| {"company_id":null,"dept_id":null,"team_id":null} 1 0 2 |
There was a problem hiding this comment.
I wonder why two {"company_id":null,"dept_id":null,"team_id":null} remain. I think it is minor and out of scope of HIVE-28727
|
@difin Could you please have a look? You are one of the most familiar engineers with Apache Icebergs' compaction. |
okumin
changed the title
deniskuzZ
reviewed
Feb 1, 2025
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/IcebergTableUtil.java
Outdated
Show resolved
Hide resolved
okumin
force-pushed
the
HIVE-28727-compaction-null
branch
from
dd1c930 to
3876695
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
tests failed
labels
|
okumin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Clean up our Iceberg utilities.
Why are the changes needed?
For clean up + add some regression tests.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No.
How was this patch tested?
I updated an existing qtest.