HIVE-28705: Fix Data Inconsistency due to missing 'IS NOT? TRUE/FALSE' parsing in Partition Filter Pruning #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indhumathi27
force-pushed
the
cbo_case
branch
from
0cca4c7 to
9e37ed6
Compare
Indhumathi27
changed the title
Indhumathi27
force-pushed
the
cbo_case
branch
from
9e37ed6 to
3570e41
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests failed
tests pending
labels
|
@ayushtkn @deniskuzZ @okumin Can you help to review the PR |
|
@zabetak Can you help to review the PR. Thanks |
|
I'm willing to review this PR but cannot immediately do so. I haven't used HMS for years and need more time to familiarize myself. |
|
@Indhumathi27 By the way, you may update either the title of this pull request or the title of the JIRA ticket |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@deniskuzZ @okumin |
kokila-19
reviewed
Feb 6, 2025
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 8, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
Indhumathi27
force-pushed
the
cbo_case
branch
from
3570e41 to
b0382ac
Compare
deniskuzZ
reviewed
Feb 10, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
deniskuzZ
reviewed
Feb 10, 2025
...etastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/PartFilterVisitor.java
Outdated
Show resolved
Hide resolved
Indhumathi27
force-pushed
the
cbo_case
branch
from
b0382ac to
e0a9b7f
Compare
|
Thanks @deniskuzZ for the review and suggestions. I have handled the same. Please check |
Indhumathi27
force-pushed
the
cbo_case
branch
from
e0a9b7f to
fc8dfd0
Compare
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
Indhumathi27
force-pushed
the
cbo_case
branch
from
fc8dfd0 to
ffbca90
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests unstable
tests pending
labels
|
/piper build pr |
deniskuzZ
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
LGTM +1, thanks @Indhumathi27 for the refactor
pending tests
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
…' parsing in Partition Filter Pruning
Indhumathi27
force-pushed
the
cbo_case
branch
from
ffbca90 to
2a101e7
Compare
|
|
@deniskuzZ Pipeline is green. Can you help to merge. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added missing support for parsing 'IS NOT? TRUE/FALSE' conditions in partition filter pruning. Specifically, it handles cases where partition filters with boolean expressions such as IS NOT TRUE or IS NOT FALSE are involved, ensuring correct partition pruning behaviour.
Why are the changes needed?
These changes address data inconsistencies in queries involving partition filter pushdown to the Hive Metastore (HMS), especially when dealing with boolean expressions like IS NOT? TRUE or IS NOT? FALSE. Previously, the partition pruning logic failed to correctly interpret these expressions, leading to incorrect results and inefficient query execution. With the new parsing logic, partition pruning now handles these complex boolean conditions properly, ensuring accurate data retrieval and better query performance.
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
Test scenarios added