Skip to content

Conversation

zratkai
Copy link
Contributor

@zratkai zratkai commented Nov 14, 2024

Change-Id: Ia9a0a92d19d33693887137c797e0662088a314db

What changes were proposed in this pull request?

Support for write order in iceberg tables. Like:
CREATE TABLE prod.db.sample WRITE ORDERED BY category ASC NULLS LAST, id DESC NULLS FIRST

Why are the changes needed?

To support write ordering in iceberg tables.

Does this PR introduce any user-facing change?

Yes, user can now use this syntax:
CREATE TABLE prod.db.sample WRITE ORDERED BY category ASC NULLS LAST, id DESC NULLS FIRST;

Is the change a dependency upgrade?

No.

How was this patch tested?

With qtest.

@okumin
Copy link
Contributor

okumin commented Jan 11, 2025

I gave +1. The remaining "Brain Method" of SemanticAnalyzer seems unavoidable.

I retriggered CI because it failed, maybe because of an accident. I'm waiting for it to be completed.

@okumin
Copy link
Contributor

okumin commented Jan 13, 2025

@zratkai I reran CI multiple times, but query_iceberg_metadata_of_unpartitioned_table always fails. Could you please have a look at if this PR causes it?
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/activity/?branch=PR-5541

My eyes could not locate the difference.
https://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-5541/17/tests

Change-Id: Ia9a0a92d19d33693887137c797e0662088a314db
Copy link

@deniskuzZ deniskuzZ merged commit bc87c4d into apache:master Jan 21, 2025
6 checks passed
henrib pushed a commit to henrib/hive that referenced this pull request Jan 31, 2025
…ATE TABLE (Zoltan Ratkai, reviewed by Ayush Saxena, Butao Zhang, Denys Kuzmenko, Shohei Okumiya)

Closes apache#5541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants