HIVE-28305: ProfileServlet: add html to output formats and prepare for profiler 3.0 #5281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests failed
tests pending
tests passed
and removed
tests pending
tests failed
labels
abstractdog
changed the title
deniskuzZ
reviewed
Jun 6, 2024
deniskuzZ
reviewed
Jun 6, 2024
kokila-19
approved these changes
Jun 6, 2024
|
ayushtkn
approved these changes
Jun 6, 2024
| return Output.valueOf(outputArg.trim().toUpperCase()); | ||
| } catch (IllegalArgumentException e) { | ||
| return Output.SVG; | ||
| LOG.warn("Output format value is invalid, returning with default HTML"); |
Member
There was a problem hiding this comment.
Can you add what value is actually configured in the log as well
LOG.warn("Output format value {} is invalid, returning with default HTML", outputArg);
Contributor
Author
|
all tests passed, merging |
asfgit
pushed a commit
that referenced
this pull request
Sep 23, 2024
…r profiler 3.0 (#5281) (Laszlo Bodor reviewed by Denys Kuzmenko, Ayush Saxena, Kokila N)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added HTML format support to ProfileServlet.
Why are the changes needed?
Because HTML is the default format for creating flamegraphs.
Does this PR introduce any user-facing change?
No, profile servlet is more like a dev tool.
Is the change a dependency upgrade?
No.
How was this patch tested?
set web port for hs2 in hive-site.xml
called localhost:10003/prof and get the flamegraph successfully
https://issues.apache.org/jira/secure/attachment/13069348/async-prof-pid-21327-cpu-2.html