Skip to content

Refactor Some Code #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushtkn merged 1 commit into from
Nov 23, 2023
Merged

Refactor Some Code #4887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions service/src/java/org/apache/hive/service/CookieSigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,8 @@ public String verifyAndExtract(String signedStr) {
String rawValue = signedStr.substring(0, index);
String currentSignature = getSignature(rawValue);

LOG.debug("Signature generated for {} inside verify is {}", rawValue, currentSignature);
if (!MessageDigest.isEqual(originalSignature.getBytes(), currentSignature.getBytes())) {
throw new IllegalArgumentException("Invalid sign, original = " + originalSignature +
" current = " + currentSignature);
throw new IllegalArgumentException("Invalid sign= " + originalSignature);
}
return rawValue;
}
Expand Down
2 changes: 1 addition & 1 deletion service/src/test/org/apache/hive/service/TestCookieSigner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ public void testVerifyAndExtractInvalidSignature() {
try {
cs.verifyAndExtract(modifedSignedStr);
} catch (IllegalArgumentException e) {
assertTrue(e.getMessage().startsWith("Invalid sign, original = "));
assertTrue(e.getMessage().startsWith("Invalid sign= "));
return;
}
fail("Expected IllegalArgumentException checking signature");
Expand Down