Skip to content

HIVE-27606 : Backport of HIVE-21171: Skip creating scratch dirs for tez if RPC is on #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sankarh merged 1 commit into from
Aug 24, 2023
Merged

HIVE-27606 : Backport of HIVE-21171: Skip creating scratch dirs for tez if RPC is on #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,11 @@ private static void setPlanPath(Configuration conf, Path hiveScratchDir) throws
// this is the unique conf ID, which is kept in JobConf as part of the plan file name
String jobID = UUID.randomUUID().toString();
Path planPath = new Path(hiveScratchDir, jobID);
FileSystem fs = planPath.getFileSystem(conf);
fs.mkdirs(planPath);
if (!HiveConf.getBoolVar(conf, ConfVars.HIVE_RPC_QUERY_PLAN)) {
FileSystem fs = planPath.getFileSystem(conf);
// since we are doing RPC creating a directory is un-necessary
fs.mkdirs(planPath);
}
HiveConf.setVar(conf, HiveConf.ConfVars.PLAN, planPath.toUri().toString());
}
}
Expand Down
13 changes: 8 additions & 5 deletions ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,11 +1509,14 @@ public Path createTezDir(Path scratchDir, Configuration conf)
scratchDir = new Path(scratchDir, userName);

Path tezDir = getTezDir(scratchDir);
FileSystem fs = tezDir.getFileSystem(conf);
LOG.debug("TezDir path set " + tezDir + " for user: " + userName);
// since we are adding the user name to the scratch dir, we do not
// need to give more permissions here
fs.mkdirs(tezDir);
if (!HiveConf.getBoolVar(conf, ConfVars.HIVE_RPC_QUERY_PLAN)) {
FileSystem fs = tezDir.getFileSystem(conf);
LOG.debug("TezDir path set " + tezDir + " for user: " + userName);
// since we are adding the user name to the scratch dir, we do not
// need to give more permissions here
// Since we are doing RPC creating a dir is not necessary
fs.mkdirs(tezDir);
}

return tezDir;

Expand Down