HIVE-27302: Iceberg: Suport write to iceberg branch #4292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgyrtkirk
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
kgyrtkirk
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
kgyrtkirk
added
tests unstable
tests pending
and removed
tests pending
tests unstable
labels
zhangbutao
force-pushed
the
HIVE-27302
branch
2 times, most recently
from
6b816ef to
0745d0f
Compare
Contributor
Author
|
@ayushtkn @deniskuzZ Can we continue with this PR? Thanks. |
ayushtkn
reviewed
Jun 7, 2023
Comment on lines
559
to
561
| default boolean isMetadataTableSupported() { | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Should be
@Deprecated
default boolean isMetadataTableSupported() {
return isTableMetaRefSupported();
}
|
Kudos, SonarCloud Quality Gate passed!
|
yeahyung
pushed a commit
to yeahyung/hive
that referenced
this pull request
Jul 20, 2023
…Butao Zhang, reviewed by Denys Kuzmenko, Ayush Saxena)
tarak271
pushed a commit
to tarak271/hive-1
that referenced
this pull request
Dec 19, 2023
…Butao Zhang, reviewed by Denys Kuzmenko, Ayush Saxena)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added ability to write iceberg branch by table identifier
dbName.tblName.branch_branchName, and this syntax refers to spark-iceberg apache/iceberg#6965.e.g, insert branch
test1of iceberg table default.ice01:insert into default.ice01.branch_test1 values(123);query branch test1:
select * from default.ice01.branch_test1;The keyword
branch_can distinguish between metadata tables and branch. User can query iceberg metadata table ussing follow syntax introduced by HIVE-25457. e.g, query metadata table refs:select * from default.ice01.refs;This PR is mainly built on HIVE-25344 and HIVE-25457, and its work mainly focused on propagating branch name to iceberg scan API, then we can query&write iceberg table.
Why are the changes needed?
Does this PR introduce any user-facing change?
Added a new table identifier to query&write iceberg table.
How was this patch tested?
mvn test -Dtest.output.overwrite -Dtest=TestIcebergCliDriver -Dqfile=write_iceberg_branch.q -pl itests/qtest-iceberg -Piceberg -Pitests -Drat.skip