Skip to content

Conversation

@amanraj2520
Copy link
Contributor

JIRA link : https://issues.apache.org/jira/browse/HIVE-27292

Zookeper 3.6.3 is End of Life (https://endoflife.date/zookeeper)

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aturoczy
Copy link

The change is legit, but won't be better to go to 3.8.1?
3.7.1 will be deprecated 2 weeks from now

@amanraj2520
Copy link
Contributor Author

@TuroczyX I agree we can upgrade to 3.8.x but according to me it will be a major version upgrade and it would require some time to test it. Personally, I do not have an issue with this, it is just that I have run all the tests in my local keeping 3.7.1 in mind. I suggest that we can create a follow up ticket to upgrade it to 3.8.x. But if the community agrees, I can bump it to 3.8.x. Let me know your thoughts.

@aturoczy
Copy link

aturoczy commented Apr 25, 2023

Agree with your points. Let's merge this one, because we could just win with this, and let's have a follow up PR with 3.8.1.

Btw: 3.7 was even bigger release :) But I guess it should work, as I remember we did not had to many problem with zookeeper versions in the past.

PS: With a draft PR we can try it out quickly the 3.8

@amanraj2520
Copy link
Contributor Author

@TuroczyX Raised this draft PR - #4270. Will upgrade it after testing. Meanwhile if this 3.7.1 change looks good to you can you please approve this.

@aturoczy
Copy link

@deniskuzZ Could you please check and if it is ok merge?

@deniskuzZ
Copy link
Member

@amanraj2520 should we wait for #4270? I've just re-triggered it

@rakeshadr
Copy link

Agree with your points. Let's merge this one, because we could just win with this, and let's have a follow up PR with 3.8.1.

Btw: 3.7 was even bigger release :) But I guess it should work, as I remember we did not had to many problem with zookeeper versions in the past.

PS: With a draft PR we can try it out quickly the 3.8
Hi aturoczy,
I agree to move to 3.8.1.
On the other side, I'd really appreciate if you could give references about the 3.7.1 deprecation plans. I could see https://zookeeper.apache.org/releases.html still says that 3.7.1 is a stable release.

@amanraj2520
Copy link
Contributor Author

@zabetak @ayushtkn @abstractdog Can we please merge this.

Copy link
Member

@zabetak zabetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge this now!

@zabetak
Copy link
Member

zabetak commented Apr 29, 2023

@deniskuzZ I think there are some legitimate failures in #4270 so don't think we should wait for that one; it can go in when its ready.

@zabetak zabetak closed this in 2826872 Apr 29, 2023
@aturoczy
Copy link

@rakeshadr I track the libs / components lifecycle on this page. https://endoflife.date/zookeeper
It is pretty accurate.

@ayushtkn
Copy link
Member

ayushtkn commented May 1, 2023

Late into the party. But for the fact, it isn't zookeeper upgrades are too calm, actually none of the dependency upgrades are calm. ex. Hadoop's Zookeeper upgrade to 3.8.1 is in a mess : apache/hadoop#5345

btw. do we plan to upgrade curator as well to 5.4.0? that seems to be the one supporting zk 3.7.1(CURATOR-596), good to do so if possible

yeahyung pushed a commit to yeahyung/hive that referenced this pull request Jul 20, 2023
tarak271 pushed a commit to tarak271/hive-1 that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants