-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27292 : Upgrade Zookeeper to 3.7.1 #4264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
The change is legit, but won't be better to go to 3.8.1? |
|
@TuroczyX I agree we can upgrade to 3.8.x but according to me it will be a major version upgrade and it would require some time to test it. Personally, I do not have an issue with this, it is just that I have run all the tests in my local keeping 3.7.1 in mind. I suggest that we can create a follow up ticket to upgrade it to 3.8.x. But if the community agrees, I can bump it to 3.8.x. Let me know your thoughts. |
|
Agree with your points. Let's merge this one, because we could just win with this, and let's have a follow up PR with 3.8.1. Btw: 3.7 was even bigger release :) But I guess it should work, as I remember we did not had to many problem with zookeeper versions in the past. PS: With a draft PR we can try it out quickly the 3.8 |
|
@TuroczyX Raised this draft PR - #4270. Will upgrade it after testing. Meanwhile if this 3.7.1 change looks good to you can you please approve this. |
|
@deniskuzZ Could you please check and if it is ok merge? |
|
@amanraj2520 should we wait for #4270? I've just re-triggered it |
|
|
@zabetak @ayushtkn @abstractdog Can we please merge this. |
zabetak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will merge this now!
|
@deniskuzZ I think there are some legitimate failures in #4270 so don't think we should wait for that one; it can go in when its ready. |
|
@rakeshadr I track the libs / components lifecycle on this page. https://endoflife.date/zookeeper |
|
Late into the party. But for the fact, it isn't zookeeper upgrades are too calm, actually none of the dependency upgrades are calm. ex. Hadoop's Zookeeper upgrade to 3.8.1 is in a mess : apache/hadoop#5345 btw. do we plan to upgrade curator as well to 5.4.0? that seems to be the one supporting zk 3.7.1(CURATOR-596), good to do so if possible |
… Zampetakis, Attila Turoczy) Closes apache#4264
… Zampetakis, Attila Turoczy) Closes apache#4264








JIRA link : https://issues.apache.org/jira/browse/HIVE-27292
Zookeper 3.6.3 is End of Life (https://endoflife.date/zookeeper)
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?