-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27234: Iceberg: CREATE BRANCH SQL implementation #4216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d7db26d to
59e762e
Compare
|
uhhhhh! This is super cool idea! I want it! Actually with this it is possible to play on dataset without any risk. I love it! I want it! Documents about it: This is my new favorite PR (After the Docker support) |
|
Didn't check the code, But it was something I was also reading coincidently 2-3 hours before only :) The main thing to chase is not creating a branch. But to insert into those branches. @zhangbutao We should chase that once we have the create in. Will review this in a day or two along with Denys. :) Just FYI. I think Iceberg has options to create Tags as well now, and an option to do cherry-pick to branches as well. They are gonna release it for spark in 1.12.0 Good to have stuff!!! Was reading here: |
|
Tags!!!! 😍 |
...c/java/org/apache/hadoop/hive/ql/ddl/table/branch/create/AlterTableCreateBranchAnalyzer.java
Show resolved
Hide resolved
|
@TuroczyX @ayushtkn yes, branch and tag are important feats in iceberg 1.2.0. I have created a umbrella ticket https://issues.apache.org/jira/browse/HIVE-27233 to track the new feats about branch&tag.
I absolutely agree. I am exploring how to achieve this in hive. Next maybe we shoud consider upgrade iceberg to latest version 1.2.1. In addition, we can refer to this PR apache/iceberg#6965 to implement the sql syntax for |
|
#4252 Upgrade iceberg to 1.2.1 in order to better integrate branch&tag features. |
|
yes, let's upgrade the iceberg version |
|
Git rebase to fix code conflicts. |
|
Kudos, SonarCloud Quality Gate passed! |
|
@deniskuzZ @ayushtkn Can we merge this PR first? Thanks. |
…eviewed by Attila Turoczy, Ayush Saxena, Denys Kuzmenko) Closes apache#4216
…eviewed by Attila Turoczy, Ayush Saxena, Denys Kuzmenko) Closes apache#4216










What changes were proposed in this pull request?
This PR refers to spark-sql about iceberg branch ddl implementation apache/iceberg#6617
If someone has different opinions about the sql syntax of branch, we can discuss here.
Why are the changes needed?
Personally, branch is more useful than snapshot in iceberg, and it is more friendly to users. We can use branch do lots of meaningfull work.
Does this PR introduce any user-facing change?
Added a new sql syntax and hive users can create iceberg branch using the sql.
How was this patch tested?
UT