-
Notifications
You must be signed in to change notification settings - Fork 4.8k
HIVE-27030 : Upgrade HIVE to Hadoop 3.3.4 #4025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
|
@abstractdog @ayushtkn @zabetak @kgyrtkirk Can you please review this. |
zabetak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge soon!
ayushtkn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it working with Tez, last time when we tried to move to 3.3.3, we moved back because of Tez.
It got me a green build though.
#3279 (comment)
|
@ayushtkn You are right when we try to integrate it with Tez, things can break. I agree fully (as you pointed out). But in that case, we can ignore this commit in Hive 4.x release. We can still have this PR merged to Hive master I think. The failure you are talking about is because Tez 0.10.2 uses 3.3.1 Hadoop and Hive will use 3.3.4 if this PR goes through. This is because Tez 0.10.2 brings in certain older jars in the classpath while a Hive job is executed as transitive dependencies for Hadoop 3.3.1. This was exactly why I was pushing for Tez 0.10.3 release which will have Hadoop 3.3.4 as we were discussing on this thread - apache/tez#213. Personally, I have added internal commits in Tez 0.10.2 just for testing in my local cluster where I just upgraded Hadoop to 3.3.4 (in Tez 0.10.2) and used that SNAPSHOT jar in the Hive master pom. Those errors were resolved. So basically, what I am again suggesting is that we can have a Tez 0.10.3 release (with Hadoop 3.3.4), if everyone agrees. Please let me know your opinion. |
This is not how things work, 4.x release is going to be from master branch, so why we will merge this. Secondly, a lot of developer develop on the master branch, we can't make the master 'knowingly' unstable. Secondly, This is dupe to #3578, and has a mention on the Tez ticket as well |
|
Got it Ayush. Will see if we can make a Tez release 0.10.3 first and then re-open this if required. Thanks for the review. |
|
Closing this for now. Will reopen if required. @zabetak @ayushtkn @abstractdog |








JIRA link : https://issues.apache.org/jira/browse/HIVE-27030
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?