HIVE-26201 QueryResultsCache should add permission check after mkdir with special permission #3267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @abstractdog , Could you please have a look at this?It same as TEZ-4412. |
Author
|
Hi @abstractdog @achennagiri ,Could you please have a look at this ? |
1 similar comment
Author
|
Hi @abstractdog @achennagiri ,Could you please have a look at this ? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIVE-26201 QueryResultsCache should add permission check after mkdir with special permission
What changes were proposed in this pull request?
TezSessionState, QueryResultsCache and Context use mkdirs(path, permission) to create directory with special permission. But If the umask is too restrictive, permissions may not work as expected. So we need to check if permission is set as expected.
Does this PR introduce any user-facing change?
no