HBASE-22710 Wrong result in one case of scan that use raw and version… #767

bsglz · 2019-10-28T09:28:11Z

…s and filter together

Apache-HBase · 2019-10-28T11:08:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
💚	mvninstall	5m 57s	master passed
💚	compile	0m 56s	master passed
💚	checkstyle	1m 32s	master passed
💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 36s	master passed
💙	spotbugs	4m 26s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 23s	master passed
		_ Patch Compile Tests _
💚	mvninstall	5m 25s	the patch passed
💚	compile	0m 57s	the patch passed
💚	javac	0m 57s	the patch passed
💔	checkstyle	1m 29s	hbase-server: The patch generated 2 new + 17 unchanged - 0 fixed = 19 total (was 17)
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	5m 0s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	17m 12s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 35s	the patch passed
💚	findbugs	4m 32s	the patch passed
		_ Other Tests _
💔	unit	31m 24s	hbase-server in the patch failed.
💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		93m 14s

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestKeepDeletes

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/Dockerfile
GITHUB PR	#767
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux fa63e05e842a 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revision	master / `d7deafa`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/testReport/
Max. process+thread count	671 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-10-29T03:45:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	1m 25s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
💚	mvninstall	6m 7s	master passed
💚	compile	1m 0s	master passed
💚	checkstyle	1m 29s	master passed
💚	shadedjars	5m 4s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 43s	master passed
💙	spotbugs	5m 0s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 58s	master passed
		_ Patch Compile Tests _
💚	mvninstall	6m 8s	the patch passed
💚	compile	1m 6s	the patch passed
💚	javac	1m 6s	the patch passed
💔	checkstyle	1m 29s	hbase-server: The patch generated 1 new + 17 unchanged - 0 fixed = 18 total (was 17)
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	5m 8s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	23m 32s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 50s	the patch passed
💚	findbugs	5m 32s	the patch passed
		_ Other Tests _
💔	unit	36m 31s	hbase-server in the patch failed.
💚	asflicense	0m 20s	The patch does not generate ASF License warnings.
		110m 6s

Reason	Tests
Failed junit tests	hadoop.hbase.regionserver.TestKeepDeletes

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/out/Dockerfile
GITHUB PR	#767
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux a3861e6cef18 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revision	master / `a881678`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/out/diff-checkstyle-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/testReport/
Max. process+thread count	673 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2019-10-29T16:22:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
💙	reexec	0m 33s	Docker mode activated.
		_ Prechecks _
💚	dupname	0m 0s	No case conflicting files found.
💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
💚	@author	0m 0s	The patch does not contain any @author tags.
💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
💚	mvninstall	5m 41s	master passed
💚	compile	0m 59s	master passed
💚	checkstyle	1m 25s	master passed
💚	shadedjars	4m 38s	branch has no errors when building our shaded downstream artifacts.
💚	javadoc	0m 37s	master passed
💙	spotbugs	4m 12s	Used deprecated FindBugs config; considering switching to SpotBugs.
💚	findbugs	4m 10s	master passed
		_ Patch Compile Tests _
💚	mvninstall	5m 22s	the patch passed
💚	compile	0m 57s	the patch passed
💚	javac	0m 57s	the patch passed
💚	checkstyle	1m 18s	the patch passed
💚	whitespace	0m 0s	The patch has no whitespace issues.
💚	shadedjars	4m 47s	patch has no errors when building our shaded downstream artifacts.
💚	hadoopcheck	17m 35s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
💚	javadoc	0m 42s	the patch passed
💚	findbugs	5m 11s	the patch passed
		_ Other Tests _
💚	unit	164m 59s	hbase-server in the patch passed.
💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		227m 21s

Subsystem	Report/Notes
Docker	Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/out/Dockerfile
GITHUB PR	#767
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 7bb463416ccb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revision	master / `7b4dd95`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/testReport/
Max. process+thread count	4213 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.0 https://yetus.apache.org

This message was automatically generated.

bsglz · 2019-10-30T02:49:16Z

@openinx Could you help to review it?

Apache-HBase · 2020-01-20T14:09:17Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 24s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	5m 55s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	checkstyle	1m 14s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
+0 🆗	spotbugs	5m 9s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 6s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 31s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	checkstyle	1m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 20s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 36s	the patch passed
+1 💚	findbugs	5m 8s	the patch passed
		_ Other Tests _
-1 ❌	unit	164m 38s	hbase-server in the patch failed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		227m 56s

Reason	Tests
Failed junit tests	hadoop.hbase.master.procedure.TestSCPWithMetaWithoutZKCoordinated

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/Dockerfile
GITHUB PR	#767
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9b3f4689ceba 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-767/out/precommit/personality/provided.sh
git revision	master / `569ac12`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/testReport/
Max. process+thread count	4993 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

gjacoby126 · 2020-02-20T00:25:18Z

@bsglz , would you mind rebasing your patch on the newest version of TestStoreScanner?

…s and filter together

bsglz · 2020-03-26T08:43:13Z

rebased.

Apache-HBase · 2020-03-31T16:32:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 28s	master passed
+1 💚	checkstyle	1m 7s	master passed
+1 💚	spotbugs	2m 1s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 8s	the patch passed
+1 💚	checkstyle	1m 7s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	10m 27s	Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚	spotbugs	2m 10s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		34m 41s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#767
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 9a4cbc2abf69 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fded2b9`
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-31T17:15:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 3s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	10m 24s	master passed
+1 💚	compile	1m 45s	master passed
+1 💚	shadedjars	8m 1s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 58s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 31s	the patch passed
+1 💚	compile	1m 40s	the patch passed
+1 💚	javac	1m 40s	the patch passed
+1 💚	shadedjars	8m 3s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	1m 2s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	10m 0s	hbase-server in the patch failed.
		55m 51s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7f924c366059 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `e5a8435`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/testReport/
Max. process+thread count	698 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-31T17:57:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 4s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	8m 11s	master passed
+1 💚	compile	1m 37s	master passed
+1 💚	shadedjars	7m 40s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 57s	the patch passed
+1 💚	compile	1m 24s	the patch passed
+1 💚	javac	1m 24s	the patch passed
+1 💚	shadedjars	7m 22s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	the patch passed
		_ Other Tests _
-1 ❌	unit	80m 7s	hbase-server in the patch failed.
		119m 13s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 14738af39ee3 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `fded2b9`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/testReport/
Max. process+thread count	5801 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

Few minor comments

...server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java

hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java

…s and filter together

Apache-HBase · 2020-04-26T12:46:17Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 0s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 15s	master passed
+1 💚	checkstyle	1m 18s	master passed
+1 💚	spotbugs	2m 17s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 57s	the patch passed
+1 💚	checkstyle	1m 17s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	13m 2s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 45s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 16s	The patch does not generate ASF License warnings.
		39m 55s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#767
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux fe40ef950871 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ec0d9d7`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1, pending QA. Let's wait for other reviews too.

virajjasani · 2020-04-26T14:20:38Z

Please review @yangzhe1991 @Apache9

Apache-HBase · 2020-04-26T15:55:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 59s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 17s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 42s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 58s	the patch passed
+1 💚	compile	1m 1s	the patch passed
+1 💚	javac	1m 1s	the patch passed
+1 💚	shadedjars	5m 39s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
-1 ❌	unit	202m 24s	hbase-server in the patch failed.
		229m 14s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f5c255bed837 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ec0d9d7`
Default Java	1.8.0_232
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/testReport/
Max. process+thread count	3281 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-04-26T16:09:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 46s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 39s	master passed
+1 💚	compile	1m 9s	master passed
+1 💚	shadedjars	5m 49s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 26s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	5m 42s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
-1 ❌	unit	215m 9s	hbase-server in the patch failed.
		242m 52s

Subsystem	Report/Notes
Docker	Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#767
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 33576f418bf6 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `ec0d9d7`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/testReport/
Max. process+thread count	3395 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-767/3/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack

Makes sense to me. Thanks for the patch @bsglz

If good by you @virajjasani , I can merge.

bsglz · 2020-04-28T03:57:13Z

Thanks very much to all of the reviewers.

Apache9

IIRC this has been discussed several times in the past, that whether we should suppor filtering when using raw scan.

The problem here is that, for a raw scan, the delete markers will also be returned, and this may cause strange behavior for some filters...

bsglz · 2020-04-28T04:35:39Z

IIRC this has been discussed several times in the past, that whether we should suppor filtering when using raw scan.

The problem here is that, for a raw scan, the delete markers will also be returned, and this may cause strange behavior for some filters...

I have skimed the discuss in HBASE-16322, so finaly, as you mentioned, "we do have some usages which use raw scan and filter together",
IMO, since the raw is not only for delete, also for ttl(HBASE-17956) and max version, make its behavier reasonable as far as possible is useful, even if it's not perfect.

bsglz · 2020-04-30T06:52:29Z

@saintstack Could you merge it, thanks.

virajjasani · 2020-04-30T08:22:01Z

Merged the PR. Thanks @bsglz

#767) Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

bsglz · 2020-04-30T09:10:31Z

Thanks very much.

#767) Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

apache#767) Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>

apache#767) Signed-off-by: stack <[email protected]> Signed-off-by: Duo Zhang <[email protected]> Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 4c42d1b) Change-Id: I829d21551b625ab6217e4b10c12dcae0a2a327b9

bsglz force-pushed the HBASE-22710 branch 2 times, most recently from 9c3f8bf to 3630a77 Compare March 26, 2020 08:22

HBASE-22710 Wrong result in one case of scan that use raw and version…

86aa2b1

…s and filter together

bsglz force-pushed the HBASE-22710 branch from 3630a77 to 86aa2b1 Compare March 26, 2020 08:42

virajjasani reviewed Apr 26, 2020

View reviewed changes

HBASE-22710 Wrong result in one case of scan that use raw and version…

8d120db

…s and filter together

virajjasani reviewed Apr 26, 2020

View reviewed changes

virajjasani requested a review from Apache9 April 26, 2020 14:20

saintstack approved these changes Apr 27, 2020

View reviewed changes

virajjasani approved these changes Apr 27, 2020

View reviewed changes

Apache9 requested changes Apr 28, 2020

View reviewed changes

Apache9 approved these changes Apr 28, 2020

View reviewed changes

virajjasani merged commit b810c9b into apache:master Apr 30, 2020

HBASE-22710 Wrong result in one case of scan that use raw and version… #767

HBASE-22710 Wrong result in one case of scan that use raw and version… #767

Uh oh!

Conversation

bsglz commented Oct 28, 2019

Uh oh!

Apache-HBase commented Oct 28, 2019

Uh oh!

Apache-HBase commented Oct 29, 2019

Uh oh!

Apache-HBase commented Oct 29, 2019

Uh oh!

bsglz commented Oct 30, 2019

Uh oh!

Apache-HBase commented Jan 20, 2020

Uh oh!

gjacoby126 commented Feb 20, 2020

Uh oh!

bsglz commented Mar 26, 2020

Uh oh!

Apache-HBase commented Mar 31, 2020

Uh oh!

Apache-HBase commented Mar 31, 2020

Uh oh!

Apache-HBase commented Mar 31, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Apache-HBase commented Apr 26, 2020

Uh oh!

virajjasani left a comment

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Apr 26, 2020

Uh oh!

Apache-HBase commented Apr 26, 2020

Uh oh!

Apache-HBase commented Apr 26, 2020

Uh oh!

saintstack left a comment

Choose a reason for hiding this comment

Uh oh!

bsglz commented Apr 28, 2020

Uh oh!

Apache9 left a comment

Choose a reason for hiding this comment

Uh oh!

bsglz commented Apr 28, 2020

Uh oh!

bsglz commented Apr 30, 2020

Uh oh!

virajjasani commented Apr 30, 2020

Uh oh!

bsglz commented Apr 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants