-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29144 Client request fails for KERBEROS with RpcConnectionRegistry #7588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
junegunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the comment here to drop the phrase "exactly once per implementation" to avoid future confusion:
Lines 34 to 38 in 9c8c9e7
| /** | |
| * Initializes the implementation with configuration and a set of providers available. This method | |
| * should be called exactly once per implementation prior to calling | |
| * {@link #selectProvider(String, User)}. | |
| */ |
This comment has been minimized.
This comment has been minimized.
|
The failed UTs have some problem and maybe the PR here changed something and cause them to fail... After digging, the problem is that, we want to hack InetAddress for the testing, but for hostname like localhost, we will always return the same InetAddress instance, so the hack in one method may affect other method and cause trouble... Plan to rewrite the failed two methods to make them more stable. Thanks. |
This comment has been minimized.
This comment has been minimized.
I modified the comment, PTAL. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
.../src/main/java/org/apache/hadoop/hbase/security/provider/AuthenticationProviderSelector.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
junegunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
No description provided.