HBASE-29531 Migrate RegionServer Status Jamon page back to JSP

[PDavid]

This is the 2/3 step of the Jamon to JSP migration: the Region Server Status page.

Did the migration the same way as for the Master Status page: #6875

Migrated the Jamon code to JSP as close as possible. Extracted the duplicated formatZKString method to new java class: ZKStringFormatter and added unit tests.

Changed the Region Server Status page back to /regionserver.jsp. Made sure that /rs-status redirects to /regionserver.jsp.

Extracted the BlockCache inline CSS styles to hbase.css file. Also extracted the large BlockCache Hit Ratio periods paging JavaScript code to separate .js file.

Introduced a src/main/resources/hbase-webapps/common directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.

Extracted the inline tablesorter initialization JavaScript code to separate file.

Signed-off-by: Duo Zhang [email protected]
(cherry picked from commit 7892207)

[ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil (#7416)

TestMasterStatusUtil.testGetFragmentationInfoTurnedOn failed in master nightly build

Signed-off-by: Nihal Jain [email protected]
Signed-off-by: Duo Zhang [email protected]
(cherry picked from commit 8ef271f)

[PDavid]

This is a backport of #7371 to branch-3. I cherry-picked the 7892207 commit which applied cleanly.

Also cherry-picked #7416 to fix TestMasterStatusUtil.testGetFragmentationInfoTurnedOn.

[PDavid]

Testing

Tested this locally the same way as described here: #7371 (comment)

Also configured HBase in pseudo-distributed mode and checked the RS Status page.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	jshint	0m 1s		jshint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 11s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 4s		branch-3 passed
+1 💚	compile	3m 45s		branch-3 passed
+1 💚	checkstyle	1m 7s		branch-3 passed
+1 💚	spotbugs	1m 35s		branch-3 passed
+1 💚	spotless	0m 45s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 6s		the patch passed
+1 💚	compile	3m 41s		the patch passed
+1 💚	javac	3m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 0s		hbase-server: The patch generated 0 new + 0 unchanged - 4 fixed = 0 total (was 4)
+1 💚	checkstyle	0m 7s		The patch passed checkstyle in hbase-shell
-0 ⚠️	rubocop	0m 3s	/results-rubocop.txt	The patch generated 1 new + 84 unchanged - 1 fixed = 85 total (was 85)
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	1m 42s		the patch passed
+1 💚	hadoopcheck	11m 50s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 45s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 17s		The patch does not generate ASF License warnings.
		41m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7491
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti jshint rubocop
uname	Linux 3de39e175df8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / 118049c
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	85 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 rubocop=1.37.1 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 15s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-3 Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	6m 20s		branch-3 passed
+1 💚	compile	2m 0s		branch-3 passed
+1 💚	javadoc	1m 1s		branch-3 passed
+1 💚	shadedjars	8m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s		Maven dependency ordering for patch
+1 💚	mvninstall	5m 46s		the patch passed
+1 💚	compile	2m 11s		the patch passed
+1 💚	javac	2m 11s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed
+1 💚	shadedjars	8m 21s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	545m 9s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	11m 5s		hbase-shell in the patch passed.
		597m 4s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7491
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 210283deec04 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-3 / 118049c
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/testReport/
Max. process+thread count	2718 (vs. ulimit of 30000)
modules	C: hbase-server hbase-shell U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7491/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[PDavid]

org.apache.hadoop.hbase.replication.TestNamespaceReplication failed in the PR build. I think it is unrelated to the changes and it run successfully locally for me.