Skip to content

[ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil #7416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PDavid merged 2 commits into from
Nov 4, 2025
Merged

[ADDENDUM] HBASE-29223 Fix TestMasterStatusUtil #7416

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ebbdf5
HBASE-29223 Fix TestMasterStatusUtil
PDavid Oct 27, 2025
bcd72e1
HBASE-29223 Improve assertion in TestMasterStatusUtil.testGetFragment…
PDavid Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion hbase-server/src/test/java/org/apache/hadoop/hbase/master/http/TestMasterStatusUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.master.http;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;

Expand Down Expand Up @@ -203,7 +204,7 @@ public void testGetFragmentationInfoTurnedOn() throws IOException {
conf.setBoolean("hbase.master.ui.fragmentation.enabled", true);
Map<String, Integer> fragmentationInfo = MasterStatusUtil.getFragmentationInfo(master, conf);
assertNotNull(fragmentationInfo);
assertEquals(1, fragmentationInfo.size());
Copy link
Contributor Author

@PDavid PDavid Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this locally was always 1 but in the nightly build it was 11:
https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1359/testReport/junit/org.apache.hadoop.hbase.master.http/TestMasterStatusUtil/health_checks___yetus_jdk17_hadoop3_backwards_compatibility_checks___testGetFragmentationInfoTurnedOn/

Copy link
Contributor

@Apache9 Apache9 Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected or something is broken?

Copy link
Contributor Author

@PDavid PDavid Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very good question.

So TestMasterStatusUtil.getFragmentationInfo() was originally part of MasterStatusServlet and I migrated it to the static util class under #6875 and added the unit tests.

Locally I got different results than in the master build but I thought this can be OK because the code invokes FSUtils.getTableFragmentation() which does:

Runs through the HBase rootdir and checks how many stores for each table have more than one file in them. Checks -ROOT- and hbase:meta too. The total percentage across all tables is stored under the special key "-TOTAL-".

As I understand, this can be different in many cases so I just end up checking here that the map is not empty.

Copy link
Contributor

@Apache9 Apache9 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

assertFalse(fragmentationInfo.isEmpty());
}

@Test
Expand Down