HBASE-29677: Thread safety in QuotaRefresherChore

[charlesconnell]

A previous contribution of mine, (https://issues.apache.org/jira/browse/HBASE-29573) while mostly effective, contains a data race bug. My company has been running with this patch for at least a month, and it solved the issue for us.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 12s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	4m 39s		master passed
+1 💚	compile	3m 54s		master passed
+1 💚	checkstyle	1m 7s		master passed
+1 💚	spotbugs	2m 3s		master passed
+1 💚	spotless	1m 0s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
-1 ❌	mvninstall	2m 17s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	2m 12s	/patch-compile-hbase-server.txt	hbase-server in the patch failed.
-0 ⚠️	javac	2m 12s	/patch-compile-hbase-server.txt	hbase-server in the patch failed.
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 7s		the patch passed
-1 ❌	spotbugs	0m 56s	/patch-spotbugs-hbase-server.txt	hbase-server in the patch failed.
-1 ❌	hadoopcheck	2m 29s		The patch causes 22 errors with Hadoop v3.3.6.
-1 ❌	hadoopcheck	4m 52s		The patch causes 22 errors with Hadoop v3.4.1.
+1 💚	spotless	0m 50s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 10s		The patch does not generate ASF License warnings.
		26m 45s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7401
JIRA Issue	HBASE-29677
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 936e5bb41d4d 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / d05966d
Default Java	Eclipse Adoptium-17.0.11+9
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt
hadoopcheck	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/artifact/yetus-general-check/output/patch-javac-3.4.1.txt
Max. process+thread count	75 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 12s		Docker mode activated.
-0 ⚠️	yetus	0m 4s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+1 💚	mvninstall	5m 28s		master passed
+1 💚	compile	1m 25s		master passed
+1 💚	javadoc	0m 44s		master passed
+1 💚	shadedjars	9m 9s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
-1 ❌	mvninstall	3m 4s	/patch-mvninstall-root.txt	root in the patch failed.
-1 ❌	compile	1m 44s	/patch-compile-hbase-server.txt	hbase-server in the patch failed.
-0 ⚠️	javac	1m 44s	/patch-compile-hbase-server.txt	hbase-server in the patch failed.
+1 💚	javadoc	0m 55s		the patch passed
-1 ❌	shadedjars	7m 32s		patch has 22 errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	2m 18s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
		33m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7401
JIRA Issue	HBASE-29677
Optional Tests	javac javadoc unit compile shadedjars
uname	Linux 4b6bd932a68f 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / d05966d
Default Java	Eclipse Adoptium-17.0.11+9
shadedjars	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/testReport/
Max. process+thread count	71 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/1/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 11s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+1 💚	mvninstall	4m 18s		master passed
+1 💚	compile	3m 48s		master passed
+1 💚	checkstyle	1m 7s		master passed
+1 💚	spotbugs	1m 51s		master passed
+1 💚	spotless	0m 52s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+1 💚	mvninstall	4m 9s		the patch passed
+1 💚	compile	3m 52s		the patch passed
+1 💚	javac	3m 52s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 6s		the patch passed
+1 💚	spotbugs	2m 7s		the patch passed
+1 💚	hadoopcheck	12m 50s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 54s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 9s		The patch does not generate ASF License warnings.
		45m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7401
JIRA Issue	HBASE-29677
Optional Tests	dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname	Linux 75e2fcfd6f4c 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / 6f3b60e
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	71 (vs. ulimit of 30000)
modules	C: hbase-server U: hbase-server
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7401/2/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

[charlesconnell]

The CI runner isn't finishing the tests, so I ran all the tests under org.apache.hadoop.hbase.quotas locally. Confirmed all non-ignored tests passed.