HBASE-23116: Fix a couple of load balancer logging nits. #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virajjasani
reviewed
Oct 4, 2019
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
Outdated
Show resolved
Hide resolved
...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
Outdated
Show resolved
Hide resolved
virajjasani
reviewed
Oct 4, 2019
...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
Show resolved
Hide resolved
...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
Outdated
Show resolved
Hide resolved
|
💔 -1 overall
This message was automatically generated. |
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly.
bharathv
commented
Oct 4, 2019
Contributor
Author
bharathv
left a comment
bharathv
left a comment
There was a problem hiding this comment.
Fixed the check-style issues but I don't think the test failures are related.
...server/src/test/java/org/apache/hadoop/hbase/master/balancer/TestStochasticLoadBalancer.java
Outdated
Show resolved
Hide resolved
virajjasani
approved these changes
Oct 4, 2019
Contributor
|
LGTM, +1. Also ran this previously failed TestSnapshotScannerHDFSAclController and it's passing locally, so it should be unrelated. Will merge this PR. |
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2019
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 06ff478)
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2019
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 06ff478)
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2019
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 06ff478)
Contributor
|
There are fix versions for 1.x on the JIRA but no commits to branch-1s. Is there a backport in progress? |
Contributor
|
Answering my own question - I am doing the backport now. Trying to get 1.5.0 RC out. |
|
💔 -1 overall
This message was automatically generated. |
bharathv
added a commit
to bharathv/hbase
that referenced
this pull request
Oct 4, 2019
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
bharathv
added a commit
to bharathv/hbase
that referenced
this pull request
Oct 4, 2019
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 06ff478)
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
This commit adds table name to the logging context when StochasticLoadBalancer is configured "per table". Added some test coverage with per-table balancer enabled and manually verified the logs to make sure the table name is formatted correctly. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 06ff478) (cherry picked from commit f89321d) Change-Id: Ieddcb04d5d3effe484eaedb3e2a9d2b677d5d84f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a typo and adds table name to the logging context when
StochasticLoadBalancer is configured "per table". Added some
test coverage with per-table balancer enabled and manually
verified the logs to make sure the table name is formatted
correctly.