Skip to content

HBASE-29204: BufferedMutatorParams#clone() should copy the requestAttributes field #6823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndimiduk merged 1 commit into from
Apr 25, 2025
Merged

HBASE-29204: BufferedMutatorParams#clone() should copy the requestAttributes field #6823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
import org.apache.hadoop.hbase.TableName;
import org.apache.yetus.audience.InterfaceAudience;

import org.apache.hbase.thirdparty.com.google.common.collect.Maps;

/**
* Parameters for instantiating a {@link BufferedMutator}.
*/
Expand Down Expand Up @@ -241,6 +243,7 @@ public BufferedMutatorParams clone() {
clone.writeBufferPeriodicFlushTimerTickMs = this.writeBufferPeriodicFlushTimerTickMs;
clone.maxKeyValueSize = this.maxKeyValueSize;
clone.maxMutations = this.maxMutations;
clone.requestAttributes = Maps.newHashMap(this.requestAttributes);
clone.pool = this.pool;
clone.listener = this.listener;
clone.implementationClassName = this.implementationClassName;
Expand Down
5 changes: 4 additions & 1 deletion hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestBufferedMutatorParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;

import java.nio.charset.StandardCharsets;
import java.util.Collection;
import java.util.List;
import java.util.concurrent.Callable;
Expand Down Expand Up @@ -141,7 +142,8 @@ public void testClone() {
BufferedMutator.ExceptionListener listener = new MockExceptionListener();
bmp.writeBufferSize(17).setWriteBufferPeriodicFlushTimeoutMs(123)
.setWriteBufferPeriodicFlushTimerTickMs(456).maxKeyValueSize(13).setMaxMutations(3737)
.pool(pool).listener(listener);
.setRequestAttribute("foo", "bar".getBytes(StandardCharsets.UTF_8)).pool(pool)
.listener(listener);
bmp.implementationClassName("someClassName");
BufferedMutatorParams clone = bmp.clone();

Expand Down Expand Up @@ -180,6 +182,7 @@ private void cloneTest(BufferedMutatorParams some, BufferedMutatorParams clone)
clone.getWriteBufferPeriodicFlushTimerTickMs());
assertEquals(some.getMaxKeyValueSize(), clone.getMaxKeyValueSize());
assertTrue(some.getMaxMutations() == clone.getMaxMutations());
assertEquals(some.requestAttributes, clone.requestAttributes);
assertTrue(some.getListener() == clone.getListener());
assertTrue(some.getPool() == clone.getPool());
assertEquals(some.getImplementationClassName(), clone.getImplementationClassName());
Expand Down