Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-29045 Support new async-profiler > 2.9 version #6614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaijunjie0101
Copy link
Contributor

Use the asprof script as default in order to support new async-profiler version.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@chaijunjie0101 chaijunjie0101 changed the title HBASE-29045 Script not found when enable profiler servlet HBASE-29045 SSupport new async-profiler > 2.9 version Jan 21, 2025
@chaijunjie0101 chaijunjie0101 changed the title HBASE-29045 SSupport new async-profiler > 2.9 version HBASE-29045 Support new async-profiler > 2.9 version Jan 21, 2025
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 0s Docker mode activated.
-1 ❌ docker 0m 3s Docker failed to build run-specific yetus/hbase:tp-25082}.
Subsystem Report/Notes
GITHUB PR #6614
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/3/console
versions git=2.17.1
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 2m 45s master passed
+1 💚 compile 0m 16s master passed
+1 💚 javadoc 0m 12s master passed
+1 💚 shadedjars 5m 36s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 52s the patch passed
+1 💚 compile 0m 16s the patch passed
+1 💚 javac 0m 16s the patch passed
+1 💚 javadoc 0m 11s the patch passed
+1 💚 shadedjars 5m 34s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 0m 50s hbase-http in the patch passed.
20m 1s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6614
Optional Tests javac javadoc unit compile shadedjars
uname Linux 963faead3970 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 522c0c5
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/3/testReport/
Max. process+thread count 342 (vs. ulimit of 30000)
modules C: hbase-http U: hbase-http
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6614/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@pankaj72981 pankaj72981 requested a review from apurtell January 21, 2025 07:01
Copy link
Contributor

@NihalJain NihalJain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnpoonia
Copy link
Contributor

I also wonder if in future instead of using the script we can directly embed async profiler with hbase and use the JAVA API directly.
https://github.com/async-profiler/async-profiler/blob/master/docs/IntegratingAsyncProfiler.md#using-java-api

I am going through the doc and seems doable.

@chaijunjie0101
Copy link
Contributor Author

I also wonder if in future instead of using the script we can directly embed async profiler with hbase and use the JAVA API directly. https://github.com/async-profiler/async-profiler/blob/master/docs/IntegratingAsyncProfiler.md#using-java-api

I am going through the doc and seems doable.

thanks for reviewing, sounds good, we could use java api as a new feature..this MR just keep use the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants