-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-29045 Support new async-profiler > 2.9 version #6614
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7a985b7
to
a23f34e
Compare
a23f34e
to
522c0c5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good.
Ref: async-profiler/async-profiler#724
I also wonder if in future instead of using the script we can directly embed async profiler with hbase and use the JAVA API directly. I am going through the doc and seems doable. |
thanks for reviewing, sounds good, we could use java api as a new feature..this MR just keep use the script. |
Use the asprof script as default in order to support new async-profiler version.