HBASE-28999 Return HTTP 503 when stateless scan REST endpoint is invoked on disabled table

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/ServiceUnavailableException.java

@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.rest;
+
+import java.io.IOException;
+import org.apache.yetus.audience.InterfaceAudience;
+
+@InterfaceAudience.Private
+public class ServiceUnavailableException extends IOException {
+  public ServiceUnavailableException(final String msg) {
+    super(msg);
+  }
+}

hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/TableResource.java

@@ -43,7 +43,7 @@
 @InterfaceAudience.Private
 public class TableResource extends ResourceBase {
 
-  String table;
+  private final String table;
   private static final Logger LOG = LoggerFactory.getLogger(TableResource.class);
 
   private static final Decoder base64Urldecoder = java.util.Base64.getUrlDecoder();
@@ -139,6 +139,9 @@ public TableScanResource getScanResource(final @PathParam("scanspec") String sca
     @DefaultValue("true") @QueryParam(Constants.SCAN_INCLUDE_START_ROW) boolean includeStartRow,
     @DefaultValue("false") @QueryParam(Constants.SCAN_INCLUDE_STOP_ROW) boolean includeStopRow) {
     try {
+      if (servlet.getAdmin().isTableDisabled(TableName.valueOf(this.table))) {
+        throw new ServiceUnavailableException("Table disabled.");
+      }
       Filter prefixFilter = null;
       Scan tableScan = new Scan();
       if (scanSpec.indexOf('*') > 0) {

hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java

@@ -71,6 +71,8 @@ public class TestTableResource {
   private static final String COLUMN_FAMILY = "test";
   private static final String COLUMN = COLUMN_FAMILY + ":qualifier";
   private static final int NUM_REGIONS = 4;
+  private static final String DISABLED_TABLE_NAME = "disabled";
+  private static final TableName DISABLED_TABLE = TableName.valueOf(DISABLED_TABLE_NAME);
   private static List<HRegionLocation> regionMap;
 
   private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil();
@@ -117,6 +119,10 @@ public static void setUpBeforeClass() throws Exception {
     regionMap = m;
     LOG.error("regions: " + regionMap);
     regionLocator.close();
+
+    TEST_UTIL.createTable(DISABLED_TABLE, "cf");
+    TEST_UTIL.getAdmin().disableTable(DISABLED_TABLE);
+    TEST_UTIL.waitTableDisabled(DISABLED_TABLE, 30);
   }
 
   @AfterClass
@@ -262,4 +268,10 @@ public void testTableNotFound() throws IOException {
     assertEquals(404, response2.getCode());
   }
 
+  @Test
+  public void testDisabledTableScan() throws IOException {
+    Response response = client.get("/" + DISABLED_TABLE_NAME + "/*", Constants.MIMETYPE_JSON);
+    assertEquals(503, response.getCode());
+    assertTrue(Bytes.toString(response.getBody()).contains("Table disabled."));
+  }
 }