Skip to content

HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w… #6495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stoty merged 1 commit into from
Nov 28, 2024
Merged

HBASE-29000 SLF4j logging backend incorrectly picked up from Hadoop w… #6495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/hbase
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,9 +804,10 @@ fi

HEAP_SETTINGS="$JAVA_HEAP_MAX $JAVA_OFFHEAP_MAX"
# by now if we're running a command it means we need logging
# prepend the logging jars to make sure they are before the ones coming from HADOOP_CLASSPATH
for f in ${HBASE_HOME}/lib/client-facing-thirdparty/log4j*.jar; do
if [ -f "${f}" ]; then
CLASSPATH="${CLASSPATH}:${f}"
CLASSPATH="${f}:${CLASSPATH}"
Copy link
Member

@ndimiduk ndimiduk Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shudder

Nice one.

fi
done

Expand Down