Skip to content

Conversation

@PDavid
Copy link
Contributor

@PDavid PDavid commented Nov 25, 2024

Changes

  • Renamed the anchor ID under "Changes of Note!" section.
  • Added a link from this section to the other "Upgrading Coprocessors to 2.0" section.
  • Fixed the anchor ID of "BucketCache Deploy Modes". This way a broken link is now fixed.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@PDavid PDavid marked this pull request as ready for review November 25, 2024 10:09
@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@NihalJain
Copy link
Contributor

+1, LGTM

@PDavid PDavid force-pushed the HBASE-20663-book-coproc-upgrade-dupl-anchor branch from 4ace639 to 2549609 Compare December 5, 2024 08:00
@Apache-HBase

This comment has been minimized.

… in HBase book

- Renamed the anchor ID under "Changes of Note!" section.
- Added a link from this section to the other "Upgrading Coprocessors to 2.0" section.
- Also fixed the grammar in one of the sentences of the "Coprocessor APIs have changed in HBase 2.0+" section.
Fixed the anchor ID of "BucketCache Deploy Modes". This way a broken link is now fixed.
@PDavid PDavid force-pushed the HBASE-20663-book-coproc-upgrade-dupl-anchor branch from 2549609 to fc1da60 Compare December 5, 2024 08:12
@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 25s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
_ Patch Compile Tests _
_ Other Tests _
1m 10s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #6493
Optional Tests
uname Linux e66a0cebc56d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / fc1da60
Max. process+thread count 40 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 38s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 2m 37s master passed
+0 🆗 refguide 1m 54s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 40s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+0 🆗 refguide 1m 52s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 40s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 12s The patch does not generate ASF License warnings.
12m 23s
Subsystem Report/Notes
Docker ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #6493
Optional Tests dupname asflicense codespell detsecrets refguide spotless
uname Linux ac868098622d 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / fc1da60
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6493/4/yetus-general-check/output/branch-site/book.html
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-6493/4/yetus-general-check/output/patch-site/book.html
Max. process+thread count 83 (vs. ulimit of 30000)
modules C: . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6493/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@PDavid PDavid requested a review from stoty December 5, 2024 14:19
Copy link
Contributor

@stoty stoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@Apache9 Apache9 changed the title HBASE-20663 Made sure coprocessor upgrade anchor ID is not duplicated in HBase book HBASE-20663 Make sure coprocessor upgrade anchor ID is not duplicated in HBase book Dec 8, 2024
@Apache9 Apache9 merged commit 1bdbb8b into apache:master Dec 8, 2024
1 check passed
@PDavid PDavid deleted the HBASE-20663-book-coproc-upgrade-dupl-anchor branch December 9, 2024 07:04
gvprathyusha6 pushed a commit to gvprathyusha6/hbase that referenced this pull request Dec 19, 2024
… in HBase book (apache#6493)

Signed-off-by: Nihal Jain <[email protected]>
Signed-off-by: Istvan Toth <[email protected]>
Signed-off-by: Duo Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants