HBASE-28921 Avoid bundling hbase-webapps folder in default jars #6430

NihalJain · 2024-11-04T06:29:02Z

Backports HBASE-28921 Avoid bundling hbase-webapps folder in default jars #6388

…he#6388) We are bundling all webapp resources in hbase-server, hbase-thrift, hbase-rest and transitively to hbase-shaded-mapreduce jar. This can be an issue, say if any of the Js projects used by hbase are vulnerable, security scan tools like sonatype start flagging the jars too as vulnerable since they contain vulnerable code. With this JIRA, we want to avoid bundling static webapp resources in our jars as these are available during runtime via hbase-webapps directory bundled in our assembly. But, we still need this for our minicluster based tests which expects it to be present in test classpath. Hence, we are copying hbase-webapps to hbase-server tests jar, which contains class SingleProcessHBaseCluster responsible for hbase minicluster creation. This class eventually needs hbase-webapps in classpath during HttpServer initialisation and hence we are adding hbase-webapps to hbase-server test resources. Signed-off-by: Istvan Toth <[email protected]> (cherry picked from commit 16c51d8)

Apache-HBase · 2024-11-05T08:54:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
			_ branch-2 Compile Tests _
+0 🆗	mvndep	1m 41s		Maven dependency ordering for branch
+1 💚	mvninstall	5m 25s		branch-2 passed
+1 💚	compile	5m 22s		branch-2 passed
+1 💚	spotless	1m 22s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s		Maven dependency ordering for patch
+1 💚	mvninstall	6m 22s		the patch passed
+1 💚	compile	4m 42s		the patch passed
+1 💚	javac	4m 42s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	xmllint	0m 4s		No new issues.
+1 💚	hadoopcheck	23m 21s		Patch does not cause any errors with Hadoop 2.10.2 or 3.3.6 3.4.0.
+1 💚	spotless	0m 56s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		82m 36s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#6430
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile
uname	Linux 4045707752ca 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `21aa278`
Default Java	Eclipse Adoptium-11.0.23+9
Max. process+thread count	83 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/console
versions	git=2.34.1 maven=3.9.8 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-05T12:00:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 58s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 9s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 1s		branch-2 passed
+1 💚	compile	1m 48s		branch-2 passed
+1 💚	javadoc	1m 5s		branch-2 passed
+1 💚	shadedjars	5m 39s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 0s		the patch passed
+1 💚	compile	1m 50s		the patch passed
+1 💚	javac	1m 50s		the patch passed
+1 💚	javadoc	1m 3s		the patch passed
+1 💚	shadedjars	5m 34s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	225m 9s		hbase-server in the patch passed.
+1 💚	unit	8m 51s		hbase-thrift in the patch passed.
+1 💚	unit	4m 1s		hbase-rest in the patch passed.
		267m 41s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#6430
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 25fc90ad6d12 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `21aa278`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/testReport/
Max. process+thread count	4212 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-05T12:50:06Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 45s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 10s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 26s		branch-2 passed
+1 💚	compile	1m 27s		branch-2 passed
+1 💚	javadoc	1m 5s		branch-2 passed
+1 💚	shadedjars	4m 44s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 25s		the patch passed
+1 💚	compile	1m 28s		the patch passed
+1 💚	javac	1m 28s		the patch passed
+1 💚	javadoc	1m 4s		the patch passed
+1 💚	shadedjars	4m 49s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	278m 52s	/patch-unit-hbase-server.txt	hbase-server in the patch failed.
+1 💚	unit	9m 45s		hbase-thrift in the patch passed.
+1 💚	unit	5m 23s		hbase-rest in the patch passed.
		319m 59s

Subsystem	Report/Notes
Docker	ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#6430
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f873f232e829 5.4.0-200-generic #220-Ubuntu SMP Fri Sep 27 13:19:16 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `21aa278`
Default Java	Temurin-1.8.0_412-b08
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/testReport/
Max. process+thread count	3991 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2024-11-05T12:58:39Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 46s		Docker mode activated.
-0 ⚠️	yetus	0m 5s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ branch-2 Compile Tests _
+0 🆗	mvndep	0m 12s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 0s		branch-2 passed
+1 💚	compile	1m 30s		branch-2 passed
+1 💚	javadoc	0m 55s		branch-2 passed
+1 💚	shadedjars	6m 3s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 52s		the patch passed
+1 💚	compile	1m 30s		the patch passed
+1 💚	javac	1m 30s		the patch passed
+1 💚	javadoc	0m 57s		the patch passed
+1 💚	shadedjars	6m 24s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
+1 💚	unit	284m 47s		hbase-server in the patch passed.
+1 💚	unit	8m 17s		hbase-thrift in the patch passed.
+1 💚	unit	5m 47s		hbase-rest in the patch passed.
		328m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#6430
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 958d27223cfe 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	branch-2 / `21aa278`
Default Java	Eclipse Adoptium-11.0.23+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/testReport/
Max. process+thread count	4291 (vs. ulimit of 30000)
modules	C: hbase-server hbase-thrift hbase-rest U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6430/2/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

NihalJain · 2024-11-06T13:08:59Z

Test failures are unrelated!

NihalJain added the backport This PR is a back port of some issue or issues already committed to master label Nov 4, 2024

This comment has been minimized.

Sign in to view

NihalJain merged commit 16d629f into apache:branch-2 Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HBASE-28921 Avoid bundling hbase-webapps folder in default jars #6430

HBASE-28921 Avoid bundling hbase-webapps folder in default jars #6430

Uh oh!

NihalJain commented Nov 4, 2024 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

NihalJain commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HBASE-28921 Avoid bundling hbase-webapps folder in default jars #6430

HBASE-28921 Avoid bundling hbase-webapps folder in default jars #6430

Uh oh!

Conversation

NihalJain commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

Apache-HBase commented Nov 5, 2024

Uh oh!

NihalJain commented Nov 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NihalJain commented Nov 4, 2024 •

edited

Loading