Skip to content

HBASE-23005 Table UI showed exception message when table is disabled #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
infraio wants to merge 1 commit into from
Closed

HBASE-23005 Table UI showed exception message when table is disabled #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4767,6 +4767,10 @@ void setRegionStateListener(RegionStateListener listener) {
this.regionStateListener = listener;
}

public boolean isTableEnabled(final TableName tableName) {
return getTableStateManager().isTableState(tableName, ZooKeeperProtos.Table.State.ENABLED);
}

private class DelayedAssignCallable implements Runnable {

Callable<?> callable;
Expand Down
24 changes: 13 additions & 11 deletions hbase-server/src/main/resources/hbase-webapps/master/table.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,24 +289,26 @@ if ( fqtn != null ) {
</tr>
<tr>
<td>Enabled</td>
<td><%= admin.isTableEnabled(table.getName()) %></td>
<td><%= master.getAssignmentManager().isTableEnabled(table.getName()) %></td>
<td>Is the table enabled</td>
</tr>
<tr>
<td>Compaction</td>
<td>
<%
try {
CompactionState compactionState = admin.getCompactionState(table.getName());
%>
<%= compactionState %>
<%
} catch (Exception e) {
// Nothing really to do here
for(StackTraceElement element : e.getStackTrace()) {
%><%= StringEscapeUtils.escapeHtml(element.toString()) %><%
if (master.getAssignmentManager().isTableEnabled(table.getName())) {
try {
CompactionState compactionState = admin.getCompactionState(table.getName());
%><%= compactionState %><%
} catch (Exception e) {
// Nothing really to do here
for(StackTraceElement element : e.getStackTrace()) {
%><%= StringEscapeUtils.escapeHtml(element.toString()) %><%
}
%> Unknown <%
}
%> Unknown <%
} else {
%><%= CompactionState.NONE %><%
}
%>
</td>
Expand Down