Skip to content

HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbeaudreault merged 5 commits into from
Mar 11, 2024
Merged

HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation #5733

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d1c6bd
HBASE-28260: Add NO_WRITE_LOCAL flag to WAL file creation
charlesconnell Feb 29, 2024
0250652
fix logic
charlesconnell Mar 1, 2024
9b8c1d8
thread avoid-local-writes into async-fs
charlesconnell Mar 6, 2024
a2bedaf
variable name
charlesconnell Mar 6, 2024
edce0ff
move noLocalWrite lookup
charlesconnell Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/ProtobufLogWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,13 @@ protected void initOutput(FileSystem fs, Path path, boolean overwritable, int bu
FSDataOutputStreamBuilder<?, ?> builder = fs.createFile(path).overwrite(overwritable)
.bufferSize(bufferSize).replication(replication).blockSize(blockSize);
if (builder instanceof DistributedFileSystem.HdfsDataOutputStreamBuilder) {
this.output =
((DistributedFileSystem.HdfsDataOutputStreamBuilder) builder).replicate().build();
DistributedFileSystem.HdfsDataOutputStreamBuilder dfsBuilder =
(DistributedFileSystem.HdfsDataOutputStreamBuilder) builder;
if (fs.getConf().getBoolean("hbase.regionserver.wal.avoid-local-writes", false)) {
Copy link
Contributor

@Apache9 Apache9 Mar 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better declare a String constants for this config.

Copy link
Contributor Author

@charlesconnell charlesconnell Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

dfsBuilder.replicate();
}
dfsBuilder.noLocalWrite();
Copy link
Contributor

@jojochuang jojochuang Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be like the following?

Suggested change
dfsBuilder.replicate();
}
dfsBuilder.noLocalWrite();
dfsBuilder.noLocalWrite();
}
dfsBuilder.replicate();

Copy link
Contributor Author

@charlesconnell charlesconnell Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad

this.output = dfsBuilder.build();
} else {
this.output = builder.build();
}
Expand Down