-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-28349 Count atomic operations against read quotas #5668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
237 changes: 237 additions & 0 deletions
237
hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestAtomicReadQuota.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,237 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.quotas; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.UUID; | ||
| import java.util.concurrent.TimeUnit; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.HBaseTestingUtil; | ||
| import org.apache.hadoop.hbase.HConstants; | ||
| import org.apache.hadoop.hbase.TableName; | ||
| import org.apache.hadoop.hbase.client.Admin; | ||
| import org.apache.hadoop.hbase.client.CheckAndMutate; | ||
| import org.apache.hadoop.hbase.client.Increment; | ||
| import org.apache.hadoop.hbase.client.Put; | ||
| import org.apache.hadoop.hbase.client.RowMutations; | ||
| import org.apache.hadoop.hbase.client.Table; | ||
| import org.apache.hadoop.hbase.security.User; | ||
| import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
| import org.apache.hadoop.hbase.testclassification.RegionServerTests; | ||
| import org.apache.hadoop.hbase.util.Bytes; | ||
| import org.apache.hadoop.hbase.util.EnvironmentEdgeManager; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @Category({ RegionServerTests.class, MediumTests.class }) | ||
| public class TestAtomicReadQuota { | ||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestAtomicReadQuota.class); | ||
| private static final Logger LOG = LoggerFactory.getLogger(TestAtomicReadQuota.class); | ||
| private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil(); | ||
| private static final TableName TABLE_NAME = TableName.valueOf(UUID.randomUUID().toString()); | ||
| private static final byte[] FAMILY = Bytes.toBytes("cf"); | ||
| private static final byte[] QUALIFIER = Bytes.toBytes("q"); | ||
|
|
||
| @AfterClass | ||
| public static void tearDown() throws Exception { | ||
| ThrottleQuotaTestUtil.clearQuotaCache(TEST_UTIL); | ||
| EnvironmentEdgeManager.reset(); | ||
| TEST_UTIL.deleteTable(TABLE_NAME); | ||
| TEST_UTIL.shutdownMiniCluster(); | ||
| } | ||
|
|
||
| @BeforeClass | ||
| public static void setUpBeforeClass() throws Exception { | ||
| TEST_UTIL.getConfiguration().setBoolean(QuotaUtil.QUOTA_CONF_KEY, true); | ||
| TEST_UTIL.getConfiguration().setInt(QuotaCache.REFRESH_CONF_KEY, 1000); | ||
| TEST_UTIL.startMiniCluster(1); | ||
| TEST_UTIL.waitTableAvailable(QuotaTableUtil.QUOTA_TABLE_NAME); | ||
| TEST_UTIL.createTable(TABLE_NAME, FAMILY); | ||
| TEST_UTIL.waitTableAvailable(TABLE_NAME); | ||
| QuotaCache.TEST_FORCE_REFRESH = true; | ||
| } | ||
|
|
||
| @Test | ||
| public void testIncrementCountedAgainstReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| Increment inc = new Increment(Bytes.toBytes(UUID.randomUUID().toString())); | ||
| inc.addColumn(FAMILY, QUALIFIER, 1); | ||
| testThrottle(table -> table.increment(inc)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testConditionalRowMutationsCountedAgainstReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| byte[] row = Bytes.toBytes(UUID.randomUUID().toString()); | ||
| Increment inc = new Increment(row); | ||
| inc.addColumn(FAMILY, Bytes.toBytes("doot"), 1); | ||
| Put put = new Put(row); | ||
| put.addColumn(FAMILY, Bytes.toBytes("doot"), Bytes.toBytes("v")); | ||
|
|
||
| RowMutations rowMutations = new RowMutations(row); | ||
| rowMutations.add(inc); | ||
| rowMutations.add(put); | ||
| testThrottle(table -> table.mutateRow(rowMutations)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNonConditionalRowMutationsOmittedFromReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| byte[] row = Bytes.toBytes(UUID.randomUUID().toString()); | ||
| Put put = new Put(row); | ||
| put.addColumn(FAMILY, Bytes.toBytes("doot"), Bytes.toBytes("v")); | ||
|
|
||
| RowMutations rowMutations = new RowMutations(row); | ||
| rowMutations.add(put); | ||
| try (Table table = getTable()) { | ||
| for (int i = 0; i < 100; i++) { | ||
| table.mutateRow(rowMutations); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testNonAtomicPutOmittedFromReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| byte[] row = Bytes.toBytes(UUID.randomUUID().toString()); | ||
| Put put = new Put(row); | ||
| put.addColumn(FAMILY, Bytes.toBytes("doot"), Bytes.toBytes("v")); | ||
| try (Table table = getTable()) { | ||
| for (int i = 0; i < 100; i++) { | ||
| table.put(put); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testNonAtomicMultiPutOmittedFromReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| Put put1 = new Put(Bytes.toBytes(UUID.randomUUID().toString())); | ||
| put1.addColumn(FAMILY, Bytes.toBytes("doot"), Bytes.toBytes("v")); | ||
| Put put2 = new Put(Bytes.toBytes(UUID.randomUUID().toString())); | ||
| put2.addColumn(FAMILY, Bytes.toBytes("doot"), Bytes.toBytes("v")); | ||
|
|
||
| Increment inc = new Increment(Bytes.toBytes(UUID.randomUUID().toString())); | ||
| inc.addColumn(FAMILY, Bytes.toBytes("doot"), 1); | ||
|
|
||
| List<Put> puts = new ArrayList<>(2); | ||
| puts.add(put1); | ||
| puts.add(put2); | ||
|
|
||
| try (Table table = getTable()) { | ||
| for (int i = 0; i < 100; i++) { | ||
| table.put(puts); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testCheckAndMutateCountedAgainstReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| byte[] row = Bytes.toBytes(UUID.randomUUID().toString()); | ||
| byte[] value = Bytes.toBytes("v"); | ||
| Put put = new Put(row); | ||
| put.addColumn(FAMILY, Bytes.toBytes("doot"), value); | ||
| CheckAndMutate checkAndMutate = | ||
| CheckAndMutate.newBuilder(row).ifEquals(FAMILY, QUALIFIER, value).build(put); | ||
|
|
||
| testThrottle(table -> table.checkAndMutate(checkAndMutate)); | ||
| } | ||
|
|
||
| @Test | ||
| public void testAtomicBatchCountedAgainstReadCapacity() throws Exception { | ||
| setupQuota(); | ||
|
|
||
| byte[] row = Bytes.toBytes(UUID.randomUUID().toString()); | ||
| Increment inc = new Increment(row); | ||
| inc.addColumn(FAMILY, Bytes.toBytes("doot"), 1); | ||
|
|
||
| List<Increment> incs = new ArrayList<>(2); | ||
| incs.add(inc); | ||
| incs.add(inc); | ||
|
|
||
| testThrottle(table -> { | ||
| Object[] results = new Object[] {}; | ||
| table.batch(incs, results); | ||
| return results; | ||
| }); | ||
| } | ||
|
|
||
| private void setupQuota() throws Exception { | ||
| try (Admin admin = TEST_UTIL.getAdmin()) { | ||
| admin.setQuota(QuotaSettingsFactory.throttleUser(User.getCurrent().getShortName(), | ||
| ThrottleType.READ_NUMBER, 1, TimeUnit.MINUTES)); | ||
| } | ||
| ThrottleQuotaTestUtil.triggerUserCacheRefresh(TEST_UTIL, false, TABLE_NAME); | ||
| } | ||
|
|
||
| private void cleanupQuota() throws Exception { | ||
| try (Admin admin = TEST_UTIL.getAdmin()) { | ||
| admin.setQuota(QuotaSettingsFactory.unthrottleUser(User.getCurrent().getShortName())); | ||
| } | ||
| ThrottleQuotaTestUtil.triggerUserCacheRefresh(TEST_UTIL, true, TABLE_NAME); | ||
| } | ||
|
|
||
| private void testThrottle(ThrowingFunction<Table, ?> request) throws Exception { | ||
| try (Table table = getTable()) { | ||
| // we have a read quota configured, so this should fail | ||
| TEST_UTIL.waitFor(60_000, () -> { | ||
| try { | ||
| request.run(table); | ||
| return false; | ||
| } catch (Exception e) { | ||
| boolean success = e.getCause() instanceof RpcThrottlingException; | ||
| if (!success) { | ||
| LOG.error("Unexpected exception", e); | ||
| } | ||
| return success; | ||
| } | ||
| }); | ||
| } finally { | ||
| cleanupQuota(); | ||
| } | ||
| } | ||
|
|
||
| private Table getTable() throws IOException { | ||
| TEST_UTIL.getConfiguration().setInt("hbase.client.pause", 100); | ||
| TEST_UTIL.getConfiguration().setInt(HConstants.HBASE_CLIENT_RETRIES_NUMBER, 1); | ||
| return TEST_UTIL.getConnection().getTableBuilder(TABLE_NAME, null).setOperationTimeout(250) | ||
| .build(); | ||
| } | ||
|
|
||
| @FunctionalInterface | ||
| private interface ThrowingFunction<I, O> { | ||
| O run(I input) throws Exception; | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.