Skip to content

HBASE-28306 Add property to customize Version information #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbeaudreault merged 1 commit into from
Jan 16, 2024
Merged

HBASE-28306 Add property to customize Version information #5621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions hbase-common/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@
<name>Apache HBase - Common</name>
<description>Common functionality for HBase</description>

<properties>
<!--
During build, one can override this property if they want to influence the
version stamped in the generated Version.java and hbase-default.xml. This has
implications for various version-related guardrails so care should be taken.
-->
<versioninfo.version>${project.version}</versioninfo.version>
</properties>

<dependencies>
<dependency>
<groupId>org.apache.hbase</groupId>
Expand Down Expand Up @@ -211,7 +220,7 @@
<phase>process-resources</phase>
<configuration>
<target>
<replace file="${project.build.outputDirectory}/hbase-default.xml" token="@@@VERSION@@@" value="${project.version}"/>
<replace file="${project.build.outputDirectory}/hbase-default.xml" token="@@@VERSION@@@" value="${versioninfo.version}"/>
</target>
</configuration>
</execution>
Expand All @@ -227,7 +236,7 @@
<property location="${project.build.directory}/generated-sources" name="generated.sources"/>

<exec executable="bash" failonerror="true">
<arg line="${basedir}/src/saveVersion.sh ${project.version} ${generated.sources}"/>
<arg line="${basedir}/src/saveVersion.sh ${versioninfo.version} ${generated.sources}"/>
</exec>
</target>
</configuration>
Expand Down