Skip to content

HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS #5558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrajeshbabu merged 3 commits into from
Feb 19, 2024
Merged

HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS #5558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e79fe78
HBASE-28238 rpcservice should perform the updateConfiguration operati…
Dec 5, 2023
d29b28d
HBASE-28238 rpcservice should perform some important admin operation …
Dec 6, 2023
270f36d
HBASE-28238 rpcservice should perform some important admin operation …
Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseRpcServicesBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ public final GetBootstrapNodesResponse getBootstrapNodes(RpcController controlle
}

@Override
@QosPriority(priority = HConstants.ADMIN_QOS)
public UpdateConfigurationResponse updateConfiguration(RpcController controller,
UpdateConfigurationRequest request) throws ServiceException {
try {
Expand Down
2 changes: 2 additions & 0 deletions hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1545,6 +1545,7 @@ public CompactRegionResponse compactRegion(final RpcController controller,
}

@Override
@QosPriority(priority = HConstants.ADMIN_QOS)
public CompactionSwitchResponse compactionSwitch(RpcController controller,
CompactionSwitchRequest request) throws ServiceException {
rpcPreCheck("compactionSwitch");
Expand Down Expand Up @@ -2223,6 +2224,7 @@ public ReplicateWALEntryResponse replicateWALEntry(final RpcController controlle
* @param request the request
*/
@Override
@QosPriority(priority = HConstants.ADMIN_QOS)
public RollWALWriterResponse rollWALWriter(final RpcController controller,
final RollWALWriterRequest request) throws ServiceException {
try {
Expand Down
3 changes: 3 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSQosFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,8 @@ public void testAnnotations() {
checkMethod(conf, "CloseRegion", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "CompactRegion", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "FlushRegion", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "UpdateConfiguration", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "CompactionSwitch", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "RollWALWriter", HConstants.ADMIN_QOS, qosFunction);
}
}