HBASE-28209: Create a jmx metrics to expose the oldWALs directory size #5528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
Nov 17, 2023
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
Thanks for submitting this, @vinayakphegde ! I have some remarks, please see it inline.
| } | ||
|
|
||
| public ScheduledChore getOldWALsDirSizeUpdaterChore() { | ||
| return new ScheduledChore("UpdateOldWALsDirSize", createDummyStoppable(), OLD_WAL_DIR_UPDATE_INTERVAL) { |
Contributor
There was a problem hiding this comment.
Can we make this interval configurable? This way we could also give the option to disable this chore altogether.
Contributor
Author
There was a problem hiding this comment.
If we disable it, won't we encounter issues with the incorrect results of the oldWALs directory size JMX metrics? Could that potentially be a problem? That's why I didn't make it configurable.
Contributor
There was a problem hiding this comment.
We could return 0 or a negative value in the metric, and document that such values mean the metric calculation is disabled. I think it's worth to make it possible for operators to disable it because this would consume a spot in the ChoreExecutor pool, which could impact execution of other important background work, such as the file cleaners.
Contributor
Author
There was a problem hiding this comment.
Got it, will modify the code for that!
| }; | ||
| } | ||
|
|
||
| public ScheduledChore getOldWALsDirSizeUpdaterChore() { |
Contributor
There was a problem hiding this comment.
Can we have this Chore imlemented on its own class? That way we don't need to define new methods on MasterWalManager that just concerns this Chore logic, like the createDummyStoppable and updateWalDirSize() above.
Contributor
Author
There was a problem hiding this comment.
Sure, Will do that
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
reviewed
Nov 28, 2023
Contributor
wchevreuil
left a comment
wchevreuil
left a comment
There was a problem hiding this comment.
We need UTs for:
- OldWALsDirSizeUpdaterChore;
- MetricsMasterWrapperImpl.getWalsDirSize
- The new metric itself (check TestMasterMetrics.testDefaultMasterMetrics)
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterWalManager.java
Outdated
Show resolved
Hide resolved
hbase-server/src/main/java/org/apache/hadoop/hbase/master/OldWALsDirSizeUpdaterChore.java
Show resolved
Hide resolved
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
wchevreuil
approved these changes
Dec 4, 2023
wchevreuil
pushed a commit
that referenced
this pull request
Dec 4, 2023
#5528) Signed-off-by: Wellington Chevreuil <[email protected]>
vinayakphegde
added a commit
to vinayakphegde/hbase
that referenced
this pull request
Dec 6, 2023
apache#5528) Signed-off-by: Wellington Chevreuil <[email protected]>
kadirozde
pushed a commit
to kadirozde/hbase
that referenced
this pull request
Jan 5, 2024
apache#5528) Signed-off-by: Wellington Chevreuil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task introduces a new JMX metric to expose the size of the 'oldWALs' directory. To calculate the directory size, a ScheduledChore is implemented, allowing for efficient computation over a potentially time-consuming operation. The ScheduledChore updates the metrics at 5-minute intervals.